| Message ID | 20230105064145.3879356-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6db51ff905362e6c79593dbda08f61f24b25971c |
| Headers | show |
| Series | macintosh/macio-adb: add missing iounmap() on error in macio_init() | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_kernel_qemu | fail | kernel (mpc885_ads_defconfig, korg-5.5.0) failed at step build. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 6 jobs. |
On Thu, 05 Jan 2023 14:41:45 +0800, Yang Yingliang wrote: > Add missing iounmap(), if request_irq() fails. > > Applied to powerpc/next. [1/1] macintosh/macio-adb: add missing iounmap() on error in macio_init() https://git.kernel.org/powerpc/c/6db51ff905362e6c79593dbda08f61f24b25971c cheers
diff --git a/drivers/macintosh/macio-adb.c b/drivers/macintosh/macio-adb.c index 55a9f8c3a150..779f1268286e 100644 --- a/drivers/macintosh/macio-adb.c +++ b/drivers/macintosh/macio-adb.c @@ -123,6 +123,7 @@ int macio_init(void) irq = irq_of_parse_and_map(adbs, 0); of_node_put(adbs); if (request_irq(irq, macio_adb_interrupt, 0, "ADB", (void *)0)) { + iounmap(adb); printk(KERN_ERR "ADB: can't get irq %d\n", irq); return -EAGAIN; }
Add missing iounmap(), if request_irq() fails. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/macintosh/macio-adb.c | 1 + 1 file changed, 1 insertion(+)