| Message ID | 20231024191115.4134426-1-milesg@linux.vnet.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] misc/led: LED state is set opposite of what is expected | expand |
On Tue, 2023-10-24 at 14:11 -0500, Glenn Miles wrote: > Testing of the LED state showed that when the LED polarity was > set to GPIO_POLARITY_ACTIVE_LOW and a low logic value was set on > the input GPIO of the LED, the LED was being turn off when it was > expected to be turned on. > > Signed-off-by: Glenn Miles <milesg@linux.vnet.ibm.com> Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
diff --git a/hw/misc/led.c b/hw/misc/led.c index f6d6d68bce..42bb43a39a 100644 --- a/hw/misc/led.c +++ b/hw/misc/led.c @@ -63,7 +63,7 @@ static void led_set_state_gpio_handler(void *opaque, int line, int new_state) LEDState *s = LED(opaque); assert(line == 0); - led_set_state(s, !!new_state != s->gpio_active_high); + led_set_state(s, !!new_state == s->gpio_active_high); } static void led_reset(DeviceState *dev)
Testing of the LED state showed that when the LED polarity was set to GPIO_POLARITY_ACTIVE_LOW and a low logic value was set on the input GPIO of the LED, the LED was being turn off when it was expected to be turned on. Signed-off-by: Glenn Miles <milesg@linux.vnet.ibm.com> --- Changes from v1: - Changed logic for readability hw/misc/led.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)