diff mbox series

[v2,11/13] migration: Use vmstate_register_any() for audio

Message ID 20231020090731.28701-12-quintela@redhat.com
State New
Headers show
Series migration: Check for duplicates on vmstate_register() | expand

Commit Message

Juan Quintela Oct. 20, 2023, 9:07 a.m. UTC 
We can have more than one audio card.

void audio_init_audiodevs(void)
{
    AudiodevListEntry *e;

    QSIMPLEQ_FOREACH(e, &audiodevs, next) {
        audio_init(e->dev, &error_fatal);
    }
}

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 audio/audio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Volker Rümelin Oct. 21, 2023, 2:55 p.m. UTC | #1 
Am 20.10.23 um 11:07 schrieb Juan Quintela:
> We can have more than one audio card.

Hi Juan,

I wouldn't use the term "audio card" here. In QEMU speak, Audiodev is an
"audio backend".

With best regards,
Volker

>
> void audio_init_audiodevs(void)
> {
>     AudiodevListEntry *e;
>
>     QSIMPLEQ_FOREACH(e, &audiodevs, next) {
>         audio_init(e->dev, &error_fatal);
>     }
> }
>
> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  audio/audio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/audio/audio.c b/audio/audio.c
> index e9815d6812..f91e05b72c 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -1781,7 +1781,7 @@ static AudioState *audio_init(Audiodev *dev, Error **errp)
>  
>      QTAILQ_INSERT_TAIL(&audio_states, s, list);
>      QLIST_INIT (&s->card_head);
> -    vmstate_register (NULL, 0, &vmstate_audio, s);
> +    vmstate_register_any(NULL, &vmstate_audio, s);
>      return s;
>  
>  out:
Juan Quintela Oct. 23, 2023, 4:29 p.m. UTC | #2 
Volker Rümelin <vr_qemu@t-online.de> wrote:
> Am 20.10.23 um 11:07 schrieb Juan Quintela:
>> We can have more than one audio card.
>
> Hi Juan,
>
> I wouldn't use the term "audio card" here. In QEMU speak, Audiodev is an
> "audio backend".

Thanks.  Changed that.

> With best regards,
> Volker
>
>>
>> void audio_init_audiodevs(void)
>> {
>>     AudiodevListEntry *e;
>>
>>     QSIMPLEQ_FOREACH(e, &audiodevs, next) {
>>         audio_init(e->dev, &error_fatal);
>>     }
>> }
>>
>> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>>  audio/audio.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/audio/audio.c b/audio/audio.c
>> index e9815d6812..f91e05b72c 100644
>> --- a/audio/audio.c
>> +++ b/audio/audio.c
>> @@ -1781,7 +1781,7 @@ static AudioState *audio_init(Audiodev *dev, Error **errp)
>>  
>>      QTAILQ_INSERT_TAIL(&audio_states, s, list);
>>      QLIST_INIT (&s->card_head);
>> -    vmstate_register (NULL, 0, &vmstate_audio, s);
>> +    vmstate_register_any(NULL, &vmstate_audio, s);
>>      return s;
>>  
>>  out:
diff mbox series

Patch

diff --git a/audio/audio.c b/audio/audio.c
index e9815d6812..f91e05b72c 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1781,7 +1781,7 @@  static AudioState *audio_init(Audiodev *dev, Error **errp)
 
     QTAILQ_INSERT_TAIL(&audio_states, s, list);
     QLIST_INIT (&s->card_head);
-    vmstate_register (NULL, 0, &vmstate_audio, s);
+    vmstate_register_any(NULL, &vmstate_audio, s);
     return s;
 
 out: