diff mbox series

[v5,3/3] qapi: re-establish linting baseline

Message ID 20231004230532.3002201-4-jsnow@redhat.com
State New
Headers show
Series qapi: static typing conversion, "pt0" | expand

Commit Message

John Snow Oct. 4, 2023, 11:05 p.m. UTC 
Some very minor housekeeping to make the linters happy once more.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 scripts/qapi/gen.py    | 2 +-
 scripts/qapi/parser.py | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

Comments

Philippe Mathieu-Daudé Oct. 5, 2023, 6:44 a.m. UTC | #1 
On 5/10/23 01:05, John Snow wrote:
> Some very minor housekeeping to make the linters happy once more.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   scripts/qapi/gen.py    | 2 +-
>   scripts/qapi/parser.py | 5 +++--
>   2 files changed, 4 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Markus Armbruster Oct. 18, 2023, 8:53 a.m. UTC | #2 
John Snow <jsnow@redhat.com> writes:

> Some very minor housekeeping to make the linters happy once more.
>
> Signed-off-by: John Snow <jsnow@redhat.com>

Queued.  Thanks!
John Snow Oct. 18, 2023, 6:41 p.m. UTC | #3 
On Wed, Oct 18, 2023, 4:53 AM Markus Armbruster <armbru@redhat.com> wrote:

> John Snow <jsnow@redhat.com> writes:
>
> > Some very minor housekeeping to make the linters happy once more.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
>
> Queued.  Thanks!
>

Hehehe. Thank you O:-)
diff mbox series

Patch

diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py
index bf5716b5f3..5412716617 100644
--- a/scripts/qapi/gen.py
+++ b/scripts/qapi/gen.py
@@ -13,8 +13,8 @@ 
 
 from contextlib import contextmanager
 import os
-import sys
 import re
+import sys
 from typing import (
     Dict,
     Iterator,
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index 22e7bcc4b1..bf31018aef 100644
--- a/scripts/qapi/parser.py
+++ b/scripts/qapi/parser.py
@@ -22,6 +22,7 @@ 
     Dict,
     List,
     Mapping,
+    Match,
     Optional,
     Set,
     Union,
@@ -563,11 +564,11 @@  def end_comment(self) -> None:
         self._switch_section(QAPIDoc.NullSection(self._parser))
 
     @staticmethod
-    def _match_at_name_colon(string: str):
+    def _match_at_name_colon(string: str) -> Optional[Match[str]]:
         return re.match(r'@([^:]*): *', string)
 
     @staticmethod
-    def _match_section_tag(string: str):
+    def _match_section_tag(string: str) -> Optional[Match[str]]:
         return re.match(r'(Returns|Since|Notes?|Examples?|TODO): *', string)
 
     def _append_body_line(self, line: str) -> None: