| Message ID | 20231017154645.95844-5-deller@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | target/hppa: Add emulation of a C3700 HP-PARISC workstation | expand |
On Tue, 17 Oct 2023, deller@kernel.org wrote: > From: Helge Deller <deller@gmx.de> > > Signed-off-by: Helge Deller <deller@gmx.de> > --- > MAINTAINERS | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Is this better squashed in the previous patch adding this device? Then checkpatch won't complain about that and splitting out just this does not make the previous patch simpler so not sure it should be separate patch. The last line adding seabios is not mentioned in commit message. Is that related ot just a fixup while you're there. Regards, BALATON Zoltan > diff --git a/MAINTAINERS b/MAINTAINERS > index ceea4c2bf2..68d086a0f3 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1174,7 +1174,7 @@ F: hw/*/etraxfs_*.c > > HP-PARISC Machines > ------------------ > -HP B160L > +HP B160L, HP C3700 > M: Richard Henderson <richard.henderson@linaro.org> > R: Helge Deller <deller@gmx.de> > S: Odd Fixes > @@ -1182,11 +1182,14 @@ F: configs/devices/hppa-softmmu/default.mak > F: hw/hppa/ > F: hw/net/*i82596* > F: hw/misc/lasi.c > +F: hw/pci-host/astro.c > F: hw/pci-host/dino.c > F: include/hw/misc/lasi.h > F: include/hw/net/lasi_82596.h > +F: include/hw/pci-host/astro.h > F: include/hw/pci-host/dino.h > F: pc-bios/hppa-firmware.img > +F: roms/seabios-hppa/ > > LoongArch Machines > ------------------ >
On 10/17/23 18:19, BALATON Zoltan wrote: > On Tue, 17 Oct 2023, deller@kernel.org wrote: >> From: Helge Deller <deller@gmx.de> >> >> Signed-off-by: Helge Deller <deller@gmx.de> >> --- >> MAINTAINERS | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) > > Is this better squashed in the previous patch adding this device? MAINTAINERS is updated by various patches/people, so keeping this change seperate makes handling and bisecting easier. > Then checkpatch won't complain about that It's just a warning, IMHO similiar to a reminder to update it. > and splitting out just this does not make the previous patch simpler > so not sure it should be separate patch. I disagree. > The last line adding seabios is not mentioned in commit message. > Is that related ot just a fixup while you're there. Yes, I noticed that this directory was missing. So, I added it while updating the entries. IMHO this additional change is so trivial that I don't think it needs to be mentioned. Helge > Regards, > BALATON Zoltan > >> diff --git a/MAINTAINERS b/MAINTAINERS >> index ceea4c2bf2..68d086a0f3 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1174,7 +1174,7 @@ F: hw/*/etraxfs_*.c >> >> HP-PARISC Machines >> ------------------ >> -HP B160L >> +HP B160L, HP C3700 >> M: Richard Henderson <richard.henderson@linaro.org> >> R: Helge Deller <deller@gmx.de> >> S: Odd Fixes >> @@ -1182,11 +1182,14 @@ F: configs/devices/hppa-softmmu/default.mak >> F: hw/hppa/ >> F: hw/net/*i82596* >> F: hw/misc/lasi.c >> +F: hw/pci-host/astro.c >> F: hw/pci-host/dino.c >> F: include/hw/misc/lasi.h >> F: include/hw/net/lasi_82596.h >> +F: include/hw/pci-host/astro.h >> F: include/hw/pci-host/dino.h >> F: pc-bios/hppa-firmware.img >> +F: roms/seabios-hppa/ >> >> LoongArch Machines >> ------------------ >> >
On Tue, 17 Oct 2023, Helge Deller wrote: > On 10/17/23 18:19, BALATON Zoltan wrote: >> On Tue, 17 Oct 2023, deller@kernel.org wrote: >>> From: Helge Deller <deller@gmx.de> >>> >>> Signed-off-by: Helge Deller <deller@gmx.de> >>> --- >>> MAINTAINERS | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> Is this better squashed in the previous patch adding this device? > > MAINTAINERS is updated by various patches/people, so keeping > this change seperate makes handling and bisecting easier. > >> Then checkpatch won't complain about that > > It's just a warning, IMHO similiar to a reminder to update it. > >> and splitting out just this does not make the previous patch simpler > so >> not sure it should be separate patch. > > I disagree. OK, I don't mind much if it's a separate patch either just did not make much sense to me to separate it from the patch that adds the files. Regards, BALATON Zoltan >> The last line adding seabios is not mentioned in commit message. >> Is that related ot just a fixup while you're there. > > Yes, I noticed that this directory was missing. > So, I added it while updating the entries. > IMHO this additional change is so trivial that I don't think it needs to be > mentioned. > > Helge > >> Regards, >> BALATON Zoltan >> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index ceea4c2bf2..68d086a0f3 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -1174,7 +1174,7 @@ F: hw/*/etraxfs_*.c >>> >>> HP-PARISC Machines >>> ------------------ >>> -HP B160L >>> +HP B160L, HP C3700 >>> M: Richard Henderson <richard.henderson@linaro.org> >>> R: Helge Deller <deller@gmx.de> >>> S: Odd Fixes >>> @@ -1182,11 +1182,14 @@ F: configs/devices/hppa-softmmu/default.mak >>> F: hw/hppa/ >>> F: hw/net/*i82596* >>> F: hw/misc/lasi.c >>> +F: hw/pci-host/astro.c >>> F: hw/pci-host/dino.c >>> F: include/hw/misc/lasi.h >>> F: include/hw/net/lasi_82596.h >>> +F: include/hw/pci-host/astro.h >>> F: include/hw/pci-host/dino.h >>> F: pc-bios/hppa-firmware.img >>> +F: roms/seabios-hppa/ >>> >>> LoongArch Machines >>> ------------------ >>> >> > >
diff --git a/MAINTAINERS b/MAINTAINERS index ceea4c2bf2..68d086a0f3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1174,7 +1174,7 @@ F: hw/*/etraxfs_*.c HP-PARISC Machines ------------------ -HP B160L +HP B160L, HP C3700 M: Richard Henderson <richard.henderson@linaro.org> R: Helge Deller <deller@gmx.de> S: Odd Fixes @@ -1182,11 +1182,14 @@ F: configs/devices/hppa-softmmu/default.mak F: hw/hppa/ F: hw/net/*i82596* F: hw/misc/lasi.c +F: hw/pci-host/astro.c F: hw/pci-host/dino.c F: include/hw/misc/lasi.h F: include/hw/net/lasi_82596.h +F: include/hw/pci-host/astro.h F: include/hw/pci-host/dino.h F: pc-bios/hppa-firmware.img +F: roms/seabios-hppa/ LoongArch Machines ------------------