mbox series

[qemu,v3,0/1] Elf2dmp: Conversion of conversions of malloc/calloc/free to g_malloc/g_new/g_free

Message ID 169753938460.23804.11418813007617535750-0@git.sr.ht
Headers show
Series Elf2dmp: Conversion of conversions of malloc/calloc/free to g_malloc/g_new/g_free | expand

Message

~h0lyalg0rithm Oct. 17, 2023, 10:43 a.m. UTC 
Remove NULL check for g_new changes

Suraj Shirvankar (1):
  Switch memory management calls to new coding conventions

 contrib/elf2dmp/addrspace.c |  7 ++-----
 contrib/elf2dmp/main.c      |  6 +++---
 contrib/elf2dmp/pdb.c       | 16 ++++++++--------
 contrib/elf2dmp/qemu_elf.c  |  7 ++-----
 4 files changed, 15 insertions(+), 21 deletions(-)

Comments

Peter Maydell Oct. 17, 2023, 1:34 p.m. UTC | #1 
On Tue, 17 Oct 2023 at 11:44, ~h0lyalg0rithm <h0lyalg0rithm@git.sr.ht> wrote:
>
> Remove NULL check for g_new changes
>
> Suraj Shirvankar (1):
>   Switch memory management calls to new coding conventions

Hi; it looks like you forgot to remove some of the NULL-checks;
the ones for the g_malloc() changes also are redundant.
Rather than making you spin a v4 of this patch, I'm going
to take this patch in to my target-arm.next tree, and
make those minor fixes here.

PS: the email address for trivial patches is
qemu-trivial@nongnu.org, not trivial@.

Thanks for this code contribution!

-- PMM