mbox series

[v3,0/3] Add emulation of AmigaOne XE board

Message ID cover.1697311794.git.balaton@eik.bme.hu
Headers show
Series Add emulation of AmigaOne XE board | expand

Message

BALATON Zoltan Oct. 14, 2023, 7:37 p.m. UTC
Changes in v3:
- Update values, comment and commit message in patch 1 again

Changes in v2:
- Update comment and commit message in patch 1 (Mark)
- Fix irq mapping in patch 2 (Volker)

Regards,
BALATON Zoltan

BALATON Zoltan (3):
  via-ide: Fix legacy mode emulation
  hw/pci-host: Add emulation of Mai Logic Articia S
  hw/ppc: Add emulation of AmigaOne XE board

 MAINTAINERS                             |   8 +
 configs/devices/ppc-softmmu/default.mak |   1 +
 hw/ide/via.c                            |  41 +++-
 hw/pci-host/Kconfig                     |   5 +
 hw/pci-host/articia.c                   | 293 ++++++++++++++++++++++++
 hw/pci-host/meson.build                 |   2 +
 hw/ppc/Kconfig                          |   7 +
 hw/ppc/amigaone.c                       | 164 +++++++++++++
 hw/ppc/meson.build                      |   2 +
 include/hw/pci-host/articia.h           |  17 ++
 10 files changed, 535 insertions(+), 5 deletions(-)
 create mode 100644 hw/pci-host/articia.c
 create mode 100644 hw/ppc/amigaone.c
 create mode 100644 include/hw/pci-host/articia.h

Comments

BALATON Zoltan Oct. 16, 2023, 10:25 p.m. UTC | #1
On Sat, 14 Oct 2023, BALATON Zoltan wrote:
> Changes in v3:
> - Update values, comment and commit message in patch 1 again
>
> Changes in v2:
> - Update comment and commit message in patch 1 (Mark)
> - Fix irq mapping in patch 2 (Volker)
>
> Regards,
> BALATON Zoltan
>
> BALATON Zoltan (3):
>  via-ide: Fix legacy mode emulation
>  hw/pci-host: Add emulation of Mai Logic Articia S
>  hw/ppc: Add emulation of AmigaOne XE board

Nick, Daniel, Cédric,

Patch 1 is not related to PPC and is still debated but just to make sure 
we don't get too close to freeze again I ask about patch 2 and 3 in the 
maintime. Not sure who will merge this series at the end but if you can 
give an Acked-by for the last two patches maybe Philippe can take care of 
the series or is any of you plan to take it via ppc?

Regards,
BALATON Zoltan

> MAINTAINERS                             |   8 +
> configs/devices/ppc-softmmu/default.mak |   1 +
> hw/ide/via.c                            |  41 +++-
> hw/pci-host/Kconfig                     |   5 +
> hw/pci-host/articia.c                   | 293 ++++++++++++++++++++++++
> hw/pci-host/meson.build                 |   2 +
> hw/ppc/Kconfig                          |   7 +
> hw/ppc/amigaone.c                       | 164 +++++++++++++
> hw/ppc/meson.build                      |   2 +
> include/hw/pci-host/articia.h           |  17 ++
> 10 files changed, 535 insertions(+), 5 deletions(-)
> create mode 100644 hw/pci-host/articia.c
> create mode 100644 hw/ppc/amigaone.c
> create mode 100644 include/hw/pci-host/articia.h
>
>
Nicholas Piggin Oct. 17, 2023, 3:59 a.m. UTC | #2
On Tue Oct 17, 2023 at 8:25 AM AEST, BALATON Zoltan wrote:
> On Sat, 14 Oct 2023, BALATON Zoltan wrote:
> > Changes in v3:
> > - Update values, comment and commit message in patch 1 again
> >
> > Changes in v2:
> > - Update comment and commit message in patch 1 (Mark)
> > - Fix irq mapping in patch 2 (Volker)
> >
> > Regards,
> > BALATON Zoltan
> >
> > BALATON Zoltan (3):
> >  via-ide: Fix legacy mode emulation
> >  hw/pci-host: Add emulation of Mai Logic Articia S
> >  hw/ppc: Add emulation of AmigaOne XE board
>
> Nick, Daniel, Cédric,
>
> Patch 1 is not related to PPC and is still debated but just to make sure 
> we don't get too close to freeze again I ask about patch 2 and 3 in the 
> maintime. Not sure who will merge this series at the end but if you can 
> give an Acked-by for the last two patches maybe Philippe can take care of 
> the series or is any of you plan to take it via ppc?

Hey,

I could take patch 2/3 via ppc tree, although I don't know much about
platform and pci so some review/ack would be good.

I guess you could submit the Amiga stuff yourself too if you wanted,
you have much better understanding of it and I don't really know how to
test either (other than a few of the free to download installer images
for one or two of those OSes).

Thanks,
Nick

>
> Regards,
> BALATON Zoltan
>
> > MAINTAINERS                             |   8 +
> > configs/devices/ppc-softmmu/default.mak |   1 +
> > hw/ide/via.c                            |  41 +++-
> > hw/pci-host/Kconfig                     |   5 +
> > hw/pci-host/articia.c                   | 293 ++++++++++++++++++++++++
> > hw/pci-host/meson.build                 |   2 +
> > hw/ppc/Kconfig                          |   7 +
> > hw/ppc/amigaone.c                       | 164 +++++++++++++
> > hw/ppc/meson.build                      |   2 +
> > include/hw/pci-host/articia.h           |  17 ++
> > 10 files changed, 535 insertions(+), 5 deletions(-)
> > create mode 100644 hw/pci-host/articia.c
> > create mode 100644 hw/ppc/amigaone.c
> > create mode 100644 include/hw/pci-host/articia.h
> >
> >
Cédric Le Goater Oct. 17, 2023, 6:41 a.m. UTC | #3
On 10/17/23 00:25, BALATON Zoltan wrote:
> On Sat, 14 Oct 2023, BALATON Zoltan wrote:
>> Changes in v3:
>> - Update values, comment and commit message in patch 1 again
>>
>> Changes in v2:
>> - Update comment and commit message in patch 1 (Mark)
>> - Fix irq mapping in patch 2 (Volker)
>>
>> Regards,
>> BALATON Zoltan
>>
>> BALATON Zoltan (3):
>>  via-ide: Fix legacy mode emulation
>>  hw/pci-host: Add emulation of Mai Logic Articia S
>>  hw/ppc: Add emulation of AmigaOne XE board
> 
> Nick, Daniel, Cédric,
> 
> Patch 1 is not related to PPC and is still debated but just to make sure we don't get too close to freeze again I ask about patch 2 and 3 in the maintime. Not sure who will merge this series at the end but if you can give an Acked-by for the last two patches maybe Philippe can take care of the series or is any of you plan to take it via ppc?

ppc should be in Nick's hands now, Daniel and I as backups.

What would help is to propose avocado tests for the machines
you maintain. Avocado can do many things, like downloading
a .zip to extract a kernel.

Thanks,

C.
BALATON Zoltan Oct. 24, 2023, 4:11 p.m. UTC | #4
On Tue, 17 Oct 2023, Nicholas Piggin wrote:
> On Tue Oct 17, 2023 at 8:25 AM AEST, BALATON Zoltan wrote:
>> On Sat, 14 Oct 2023, BALATON Zoltan wrote:
>>> Changes in v3:
>>> - Update values, comment and commit message in patch 1 again
>>>
>>> Changes in v2:
>>> - Update comment and commit message in patch 1 (Mark)
>>> - Fix irq mapping in patch 2 (Volker)
>>>
>>> Regards,
>>> BALATON Zoltan
>>>
>>> BALATON Zoltan (3):
>>>  via-ide: Fix legacy mode emulation
>>>  hw/pci-host: Add emulation of Mai Logic Articia S
>>>  hw/ppc: Add emulation of AmigaOne XE board
>>
>> Nick, Daniel, Cédric,
>>
>> Patch 1 is not related to PPC and is still debated but just to make sure
>> we don't get too close to freeze again I ask about patch 2 and 3 in the
>> maintime. Not sure who will merge this series at the end but if you can
>> give an Acked-by for the last two patches maybe Philippe can take care of
>> the series or is any of you plan to take it via ppc?
>
> Hey,
>
> I could take patch 2/3 via ppc tree, although I don't know much about
> platform and pci so some review/ack would be good.
>
> I guess you could submit the Amiga stuff yourself too if you wanted,
> you have much better understanding of it and I don't really know how to
> test either (other than a few of the free to download installer images
> for one or two of those OSes).

I can't send pull requests, don't have a signing key and never did that. 
So far it worked by submitting patches and the ppc maintainer merging them 
so I'd stay with that work flow. I'm listed as maintainer so if there's 
some problem with these machines I'll look to fix them and I try to 
make sure these work so you'd only need to do usual integration testing 
before pull and don't have to take responsibility for these machines 
otherwise.

Currently Mark wanted an alternative approach instead of patch 1 which was 
tested so just waiting for him to finalise that then remaining patch 2-4 
from latest version of this series (v5) should apply but I can resubmit 
that as v6 with a Based-on: tag if that helps.

I don't know who will metge Mark's series, Philippe seems to have some IDE 
patches queued so maybe he can take that too then might as well take this 
series if you give an Acked-by for it.

Regards,
BALATON Zoltan