| Message ID | 935735389830bbe8407d95ebf89632792bf11a30.1696185261.git.dxu@dxuuu.xyz |
|---|---|
| State | New |
| Headers | show |
| Series | Small fixes for qga | expand |
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com> On Sun, Oct 1, 2023 at 9:39 PM Daniel Xu <dxu@dxuuu.xyz> wrote: > If output is being captured for a guest-exec invocation, the out-data > and err-data fields of guest-exec-status are only populated after the > process is reaped. This is somewhat counter intuitive and too late to > change. Thus, it would be good to document the behavior. > > Signed-off-by: Daniel Xu <dxu@dxuuu.xyz> > --- > qga/qapi-schema.json | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json > index b720dd4379..876e2a8ea8 100644 > --- a/qga/qapi-schema.json > +++ b/qga/qapi-schema.json > @@ -1220,11 +1220,13 @@ > # @signal: signal number (linux) or unhandled exception code (windows) > # if the process was abnormally terminated. > # > -# @out-data: base64-encoded stdout of the process > +# @out-data: base64-encoded stdout of the process. This field will only > +# be populated after the process exits. > # > -# @err-data: base64-encoded stderr of the process Note: @out-data and > +# @err-data: base64-encoded stderr of the process. Note: @out-data and > # @err-data are present only if 'capture-output' was specified for > -# 'guest-exec' > +# 'guest-exec'. This field will only be populated after the process > +# exits. > # > # @out-truncated: true if stdout was not fully captured due to size > # limitation. > -- > 2.42.0 > >
Daniel Xu <dxu@dxuuu.xyz> writes: > If output is being captured for a guest-exec invocation, the out-data > and err-data fields of guest-exec-status are only populated after the > process is reaped. This is somewhat counter intuitive and too late to > change. Thus, it would be good to document the behavior. > > Signed-off-by: Daniel Xu <dxu@dxuuu.xyz> > --- > qga/qapi-schema.json | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json > index b720dd4379..876e2a8ea8 100644 > --- a/qga/qapi-schema.json > +++ b/qga/qapi-schema.json > @@ -1220,11 +1220,13 @@ > # @signal: signal number (linux) or unhandled exception code (windows) > # if the process was abnormally terminated. > # > -# @out-data: base64-encoded stdout of the process > +# @out-data: base64-encoded stdout of the process. This field will only > +# be populated after the process exits. > # > -# @err-data: base64-encoded stderr of the process Note: @out-data and > +# @err-data: base64-encoded stderr of the process. Note: @out-data and > # @err-data are present only if 'capture-output' was specified for > -# 'guest-exec' > +# 'guest-exec'. This field will only be populated after the process > +# exits. > # > # @out-truncated: true if stdout was not fully captured due to size > # limitation. Two spaces between sentences for consistency, please. With that: Acked-by: Markus Armbruster <armbru@redhat.com>
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index b720dd4379..876e2a8ea8 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -1220,11 +1220,13 @@ # @signal: signal number (linux) or unhandled exception code (windows) # if the process was abnormally terminated. # -# @out-data: base64-encoded stdout of the process +# @out-data: base64-encoded stdout of the process. This field will only +# be populated after the process exits. # -# @err-data: base64-encoded stderr of the process Note: @out-data and +# @err-data: base64-encoded stderr of the process. Note: @out-data and # @err-data are present only if 'capture-output' was specified for -# 'guest-exec' +# 'guest-exec'. This field will only be populated after the process +# exits. # # @out-truncated: true if stdout was not fully captured due to size # limitation.
If output is being captured for a guest-exec invocation, the out-data and err-data fields of guest-exec-status are only populated after the process is reaped. This is somewhat counter intuitive and too late to change. Thus, it would be good to document the behavior. Signed-off-by: Daniel Xu <dxu@dxuuu.xyz> --- qga/qapi-schema.json | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)