mbox

[PULL,0/2] hw/ufs: fixes

Message ID cover.1697090890.git.jeuk20.kim@samsung.com
State New
Headers show

Pull-request

https://gitlab.com/jeuk20.kim/qemu.git tags/pull-ufs-20231012

Message

Jeuk Kim Oct. 12, 2023, 6:31 a.m. UTC
From: Jeuk Kim <jeuk20.kim@samsung.com>

The following changes since commit a51e5124a655b3dad80b36b18547cb1eca2c5eb2:

  Merge tag 'pull-omnibus-111023-1' of https://gitlab.com/stsquad/qemu into staging (2023-10-11 09:43:10 -0400)

are available in the Git repository at:

  https://gitlab.com/jeuk20.kim/qemu.git tags/pull-ufs-20231012

for you to fetch changes up to 8466aa53d623377e114895c6563face25370d7da:

  hw/ufs: Fix incorrect register fields (2023-10-12 14:29:20 +0900)

----------------------------------------------------------------
hw/ufs: fixes

----------------------------------------------------------------
Jeuk Kim (2):
      hw/ufs: Fix code coverity issues
      hw/ufs: Fix incorrect register fields

 hw/ufs/lu.c            | 16 +++++++---------
 hw/ufs/ufs.c           | 10 +++++-----
 include/block/ufs.h    |  4 ++--
 tests/qtest/ufs-test.c |  2 +-
 4 files changed, 15 insertions(+), 17 deletions(-)

Comments

Stefan Hajnoczi Oct. 12, 2023, 5:22 p.m. UTC | #1
On Thu, 12 Oct 2023 at 02:33, Jeuk Kim <jeuk20.kim@gmail.com> wrote:
>
> From: Jeuk Kim <jeuk20.kim@samsung.com>
>
> The following changes since commit a51e5124a655b3dad80b36b18547cb1eca2c5eb2:
>
>   Merge tag 'pull-omnibus-111023-1' of https://gitlab.com/stsquad/qemu into staging (2023-10-11 09:43:10 -0400)
>
> are available in the Git repository at:
>
>   https://gitlab.com/jeuk20.kim/qemu.git tags/pull-ufs-20231012
>
> for you to fetch changes up to 8466aa53d623377e114895c6563face25370d7da:
>
>   hw/ufs: Fix incorrect register fields (2023-10-12 14:29:20 +0900)
>
> ----------------------------------------------------------------
> hw/ufs: fixes

The following CI failure has occurred:

>>> QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon G_TEST_DBUS_DAEMON=/home/gitlab-runner/builds/-LCfcJ2T/0/qemu-project/qemu/tests/dbus-vmstate-daemon.sh QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-aarch64 MALLOC_PERTURB_=72 /home/gitlab-runner/builds/-LCfcJ2T/0/qemu-project/qemu/build/tests/qtest/qos-test --tap -k
――――――――――――――――――――――――――――――――――――― ✀ ―――――――――――――――――――――――――――――――――――――
stderr:
**
ERROR:../tests/qtest/ufs-test.c:113:ufs_send_nop_out:
'FIELD_EX32(ufs_rreg(ufs, A_IS), IS, UTRCS)' should be TRUE
(test program exited with status code -6)

https://gitlab.com/qemu-project/qemu/-/jobs/5281094630

Please take a look and send a v2 pull request once it has been fixed. Thanks!

Stefan

>
> ----------------------------------------------------------------
> Jeuk Kim (2):
>       hw/ufs: Fix code coverity issues
>       hw/ufs: Fix incorrect register fields
>
>  hw/ufs/lu.c            | 16 +++++++---------
>  hw/ufs/ufs.c           | 10 +++++-----
>  include/block/ufs.h    |  4 ++--
>  tests/qtest/ufs-test.c |  2 +-
>  4 files changed, 15 insertions(+), 17 deletions(-)
>