| Message ID | 20231012085005.848149-1-mironov@fintech.ru |
|---|---|
| State | New |
| Headers | show |
Hi Sergey, On 12/10/23 10:50, Sergey Mironov wrote: > 6 out of 7 calls to get_arm_cp_reginfo() are checked > > Signed-off-by: Sergey Mironov <mironov@fintech.ru> > --- > target/arm/helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/arm/helper.c b/target/arm/helper.c > index 74fbb6e1d7..cffbbaf571 100644 > --- a/target/arm/helper.c > +++ b/target/arm/helper.c > @@ -198,6 +198,7 @@ static void add_cpreg_to_list(gpointer key, gpointer opaque) > uint32_t regidx = (uintptr_t)key; > const ARMCPRegInfo *ri = get_arm_cp_reginfo(cpu->cp_regs, regidx); > > + assert(ri != NULL); > if (!(ri->type & (ARM_CP_NO_RAW | ARM_CP_ALIAS))) { > cpu->cpreg_indexes[cpu->cpreg_array_len] = cpreg_to_kvm_id(regidx); > /* The value array need not be initialized at this point */ 100742 patches would be the biggest series I ever saw on this list =)
It was my mistake :)
diff --git a/target/arm/helper.c b/target/arm/helper.c index 74fbb6e1d7..cffbbaf571 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -198,6 +198,7 @@ static void add_cpreg_to_list(gpointer key, gpointer opaque) uint32_t regidx = (uintptr_t)key; const ARMCPRegInfo *ri = get_arm_cp_reginfo(cpu->cp_regs, regidx); + assert(ri != NULL); if (!(ri->type & (ARM_CP_NO_RAW | ARM_CP_ALIAS))) { cpu->cpreg_indexes[cpu->cpreg_array_len] = cpreg_to_kvm_id(regidx); /* The value array need not be initialized at this point */
6 out of 7 calls to get_arm_cp_reginfo() are checked Signed-off-by: Sergey Mironov <mironov@fintech.ru> --- target/arm/helper.c | 1 + 1 file changed, 1 insertion(+)