Message ID | 1326461336-5699-1-git-send-email-hdegoede@redhat.com |
---|---|
State | New |
Headers | show |
On 01/13/12 14:28, Hans de Goede wrote: > According to the EHCI spec port ownerhsip should revert to the EHCI controller > on device disconnect. This fixes the problem of a port getting stuck on USB 1 > when using redirection and plugging in a USB 2 device after a USB 1 device > has been redirected. Patch added to usb patch queue. thanks, Gerd
Am 23.01.2012 15:51, schrieb Gerd Hoffmann: > On 01/13/12 14:28, Hans de Goede wrote: >> According to the EHCI spec port ownerhsip should revert to the EHCI controller ownership >> on device disconnect. This fixes the problem of a port getting stuck on USB 1 >> when using redirection and plugging in a USB 2 device after a USB 1 device >> has been redirected. > > Patch added to usb patch queue. Andreas
On 01/23/12 17:12, Andreas Färber wrote: > Am 23.01.2012 15:51, schrieb Gerd Hoffmann: >> On 01/13/12 14:28, Hans de Goede wrote: >>> According to the EHCI spec port ownerhsip should revert to the EHCI controller > > ownership Fixed. thanks, Gerd
diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index a946e1d..69bcc4b 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -764,6 +764,11 @@ static void ehci_detach(USBPort *port) USBPort *companion = s->companion_ports[port->index]; companion->ops->detach(companion); companion->dev = NULL; + /* + * EHCI spec 4.2.2: "When a disconnect occurs... On the event, + * the port ownership is returned immediately to the EHCI controller." + */ + *portsc &= ~PORTSC_POWNER; return; }
According to the EHCI spec port ownerhsip should revert to the EHCI controller on device disconnect. This fixes the problem of a port getting stuck on USB 1 when using redirection and plugging in a USB 2 device after a USB 1 device has been redirected. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- hw/usb-ehci.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)