| Message ID | cfa02bbb-cdaf-4310-ac40-a2837d33c710@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | mips: fix abort on integer overflow | expand |
On 9/24/23 07:16, Mikulas Patocka wrote: > Qemu mips userspace emulation crashes with "qemu: unhandled CPU exception > 0x15 - aborting" when one of the integer arithmetic instructions detects > an overflow. > > This patch fixes it so that it delivers SIGFPE with FPE_INTOVF instead. > > Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> > Cc: qemu-stable@nongnu.org > > --- > linux-user/mips/cpu_loop.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > Index: qemu/linux-user/mips/cpu_loop.c > =================================================================== > --- qemu.orig/linux-user/mips/cpu_loop.c > +++ qemu/linux-user/mips/cpu_loop.c > @@ -180,7 +180,9 @@ done_syscall: > } > force_sig_fault(TARGET_SIGFPE, si_code, env->active_tc.PC); > break; > - > + case EXCP_OVERFLOW: > + do_tr_or_bp(env, BRK_OVERFLOW, false); > + break; Just call force_sig_fault directly. r~
Index: qemu/linux-user/mips/cpu_loop.c =================================================================== --- qemu.orig/linux-user/mips/cpu_loop.c +++ qemu/linux-user/mips/cpu_loop.c @@ -180,7 +180,9 @@ done_syscall: } force_sig_fault(TARGET_SIGFPE, si_code, env->active_tc.PC); break; - + case EXCP_OVERFLOW: + do_tr_or_bp(env, BRK_OVERFLOW, false); + break; /* The code below was inspired by the MIPS Linux kernel trap * handling code in arch/mips/kernel/traps.c. */
Qemu mips userspace emulation crashes with "qemu: unhandled CPU exception 0x15 - aborting" when one of the integer arithmetic instructions detects an overflow. This patch fixes it so that it delivers SIGFPE with FPE_INTOVF instead. Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Cc: qemu-stable@nongnu.org --- linux-user/mips/cpu_loop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)