mbox series

[v5,0/5] ppc, fbdev: Clean up fbdev mmap helper

Message ID 20230922080636.26762-1-tzimmermann@suse.de (mailing list archive)
Headers show
Series ppc, fbdev: Clean up fbdev mmap helper | expand

Message

Thomas Zimmermann Sept. 22, 2023, 8:04 a.m. UTC
Clean up and rename fb_pgprotect() to work without struct file. Then
refactor the implementation for PowerPC. This change has been discussed
at [1] in the context of refactoring fbdev's mmap code.

The first two patches update fbdev and replace fbdev's fb_pgprotect()
with pgprot_framebuffer() on all architectures. The new helper's stream-
lined interface enables more refactoring within fbdev's mmap
implementation.

Patches 3 to 5 adapt PowerPC's internal interfaces to provide
phys_mem_access_prot() that works without struct file. Neither the
architecture code or fbdev helpers need the parameter.

v5:
	* improve commit descriptions (Javier)
	* add missing tags (Geert)
v4:
	* fix commit message (Christophe)
v3:
	* rename fb_pgrotect() to pgprot_framebuffer() (Arnd)
v2:
	* reorder patches to simplify merging (Michael)

[1] https://lore.kernel.org/linuxppc-dev/5501ba80-bdb0-6344-16b0-0466a950f82c@suse.com/

Thomas Zimmermann (5):
  fbdev: Avoid file argument in fb_pgprotect()
  fbdev: Replace fb_pgprotect() with pgprot_framebuffer()
  arch/powerpc: Remove trailing whitespaces
  arch/powerpc: Remove file parameter from phys_mem_access_prot code
  arch/powerpc: Call internal __phys_mem_access_prot() in fbdev code

 arch/ia64/include/asm/fb.h                | 15 +++++++--------
 arch/m68k/include/asm/fb.h                | 19 ++++++++++---------
 arch/mips/include/asm/fb.h                | 11 +++++------
 arch/powerpc/include/asm/book3s/pgtable.h | 10 ++++++++--
 arch/powerpc/include/asm/fb.h             | 13 +++++--------
 arch/powerpc/include/asm/machdep.h        | 13 ++++++-------
 arch/powerpc/include/asm/nohash/pgtable.h | 10 ++++++++--
 arch/powerpc/include/asm/pci.h            |  4 +---
 arch/powerpc/kernel/pci-common.c          |  3 +--
 arch/powerpc/mm/mem.c                     |  8 ++++----
 arch/sparc/include/asm/fb.h               | 15 +++++++++------
 arch/x86/include/asm/fb.h                 | 10 ++++++----
 arch/x86/video/fbdev.c                    | 15 ++++++++-------
 drivers/video/fbdev/core/fb_chrdev.c      |  3 ++-
 include/asm-generic/fb.h                  | 12 ++++++------
 15 files changed, 86 insertions(+), 75 deletions(-)


base-commit: f8d21cb17a99b75862196036bb4bb93ee9637b74

Comments

Thomas Zimmermann Sept. 25, 2023, 8 a.m. UTC | #1
FYI, I intent to merge patches 1 and 2 of this patchset into 
drm-misc-next. The updates for PowerPC can be merged through PPC trees 
later. Let me know if this does not work for you.

Best regards
Thomas

Am 22.09.23 um 10:04 schrieb Thomas Zimmermann:
> Clean up and rename fb_pgprotect() to work without struct file. Then
> refactor the implementation for PowerPC. This change has been discussed
> at [1] in the context of refactoring fbdev's mmap code.
> 
> The first two patches update fbdev and replace fbdev's fb_pgprotect()
> with pgprot_framebuffer() on all architectures. The new helper's stream-
> lined interface enables more refactoring within fbdev's mmap
> implementation.
> 
> Patches 3 to 5 adapt PowerPC's internal interfaces to provide
> phys_mem_access_prot() that works without struct file. Neither the
> architecture code or fbdev helpers need the parameter.
> 
> v5:
> 	* improve commit descriptions (Javier)
> 	* add missing tags (Geert)
> v4:
> 	* fix commit message (Christophe)
> v3:
> 	* rename fb_pgrotect() to pgprot_framebuffer() (Arnd)
> v2:
> 	* reorder patches to simplify merging (Michael)
> 
> [1] https://lore.kernel.org/linuxppc-dev/5501ba80-bdb0-6344-16b0-0466a950f82c@suse.com/
> 
> Thomas Zimmermann (5):
>    fbdev: Avoid file argument in fb_pgprotect()
>    fbdev: Replace fb_pgprotect() with pgprot_framebuffer()
>    arch/powerpc: Remove trailing whitespaces
>    arch/powerpc: Remove file parameter from phys_mem_access_prot code
>    arch/powerpc: Call internal __phys_mem_access_prot() in fbdev code
> 
>   arch/ia64/include/asm/fb.h                | 15 +++++++--------
>   arch/m68k/include/asm/fb.h                | 19 ++++++++++---------
>   arch/mips/include/asm/fb.h                | 11 +++++------
>   arch/powerpc/include/asm/book3s/pgtable.h | 10 ++++++++--
>   arch/powerpc/include/asm/fb.h             | 13 +++++--------
>   arch/powerpc/include/asm/machdep.h        | 13 ++++++-------
>   arch/powerpc/include/asm/nohash/pgtable.h | 10 ++++++++--
>   arch/powerpc/include/asm/pci.h            |  4 +---
>   arch/powerpc/kernel/pci-common.c          |  3 +--
>   arch/powerpc/mm/mem.c                     |  8 ++++----
>   arch/sparc/include/asm/fb.h               | 15 +++++++++------
>   arch/x86/include/asm/fb.h                 | 10 ++++++----
>   arch/x86/video/fbdev.c                    | 15 ++++++++-------
>   drivers/video/fbdev/core/fb_chrdev.c      |  3 ++-
>   include/asm-generic/fb.h                  | 12 ++++++------
>   15 files changed, 86 insertions(+), 75 deletions(-)
> 
> 
> base-commit: f8d21cb17a99b75862196036bb4bb93ee9637b74
Michael Ellerman Oct. 18, 2023, 10:48 a.m. UTC | #2
Thomas Zimmermann <tzimmermann@suse.de> writes:
> FYI, I intent to merge patches 1 and 2 of this patchset into 
> drm-misc-next. The updates for PowerPC can be merged through PPC trees 
> later. Let me know if this does not work for you.

Hi Thomas,

Sorry for the late reply, I was on leave.

Yeah that's fine.

cheers

> Am 22.09.23 um 10:04 schrieb Thomas Zimmermann:
>> Clean up and rename fb_pgprotect() to work without struct file. Then
>> refactor the implementation for PowerPC. This change has been discussed
>> at [1] in the context of refactoring fbdev's mmap code.
>> 
>> The first two patches update fbdev and replace fbdev's fb_pgprotect()
>> with pgprot_framebuffer() on all architectures. The new helper's stream-
>> lined interface enables more refactoring within fbdev's mmap
>> implementation.
>> 
>> Patches 3 to 5 adapt PowerPC's internal interfaces to provide
>> phys_mem_access_prot() that works without struct file. Neither the
>> architecture code or fbdev helpers need the parameter.
>> 
>> v5:
>> 	* improve commit descriptions (Javier)
>> 	* add missing tags (Geert)
>> v4:
>> 	* fix commit message (Christophe)
>> v3:
>> 	* rename fb_pgrotect() to pgprot_framebuffer() (Arnd)
>> v2:
>> 	* reorder patches to simplify merging (Michael)
>> 
>> [1] https://lore.kernel.org/linuxppc-dev/5501ba80-bdb0-6344-16b0-0466a950f82c@suse.com/
>> 
>> Thomas Zimmermann (5):
>>    fbdev: Avoid file argument in fb_pgprotect()
>>    fbdev: Replace fb_pgprotect() with pgprot_framebuffer()
>>    arch/powerpc: Remove trailing whitespaces
>>    arch/powerpc: Remove file parameter from phys_mem_access_prot code
>>    arch/powerpc: Call internal __phys_mem_access_prot() in fbdev code
>> 
>>   arch/ia64/include/asm/fb.h                | 15 +++++++--------
>>   arch/m68k/include/asm/fb.h                | 19 ++++++++++---------
>>   arch/mips/include/asm/fb.h                | 11 +++++------
>>   arch/powerpc/include/asm/book3s/pgtable.h | 10 ++++++++--
>>   arch/powerpc/include/asm/fb.h             | 13 +++++--------
>>   arch/powerpc/include/asm/machdep.h        | 13 ++++++-------
>>   arch/powerpc/include/asm/nohash/pgtable.h | 10 ++++++++--
>>   arch/powerpc/include/asm/pci.h            |  4 +---
>>   arch/powerpc/kernel/pci-common.c          |  3 +--
>>   arch/powerpc/mm/mem.c                     |  8 ++++----
>>   arch/sparc/include/asm/fb.h               | 15 +++++++++------
>>   arch/x86/include/asm/fb.h                 | 10 ++++++----
>>   arch/x86/video/fbdev.c                    | 15 ++++++++-------
>>   drivers/video/fbdev/core/fb_chrdev.c      |  3 ++-
>>   include/asm-generic/fb.h                  | 12 ++++++------
>>   15 files changed, 86 insertions(+), 75 deletions(-)
>> 
>> 
>> base-commit: f8d21cb17a99b75862196036bb4bb93ee9637b74
>
> -- 
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Frankenstrasse 146, 90461 Nuernberg, Germany
> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
> HRB 36809 (AG Nuernberg)
Michael Ellerman Nov. 13, 2023, 2:45 a.m. UTC | #3
On Fri, 22 Sep 2023 10:04:54 +0200, Thomas Zimmermann wrote:
> Clean up and rename fb_pgprotect() to work without struct file. Then
> refactor the implementation for PowerPC. This change has been discussed
> at [1] in the context of refactoring fbdev's mmap code.
> 
> The first two patches update fbdev and replace fbdev's fb_pgprotect()
> with pgprot_framebuffer() on all architectures. The new helper's stream-
> lined interface enables more refactoring within fbdev's mmap
> implementation.
> 
> [...]

Patches 3-5 applied to powerpc/fixes.

[3/5] arch/powerpc: Remove trailing whitespaces
      https://git.kernel.org/powerpc/c/322948c3198cf80e7c10d953ddad24ebd85757cd
[4/5] arch/powerpc: Remove file parameter from phys_mem_access_prot code
      https://git.kernel.org/powerpc/c/1f92a844c35e483c00bab8a7b7d39c555ee799d8
[5/5] arch/powerpc: Call internal __phys_mem_access_prot() in fbdev code
      https://git.kernel.org/powerpc/c/deebe5f607d7f72f83c41163191ad0c1c4356385

cheers
Thomas Zimmermann Nov. 13, 2023, 9:22 a.m. UTC | #4
Am 13.11.23 um 03:45 schrieb Michael Ellerman:
> On Fri, 22 Sep 2023 10:04:54 +0200, Thomas Zimmermann wrote:
>> Clean up and rename fb_pgprotect() to work without struct file. Then
>> refactor the implementation for PowerPC. This change has been discussed
>> at [1] in the context of refactoring fbdev's mmap code.
>>
>> The first two patches update fbdev and replace fbdev's fb_pgprotect()
>> with pgprot_framebuffer() on all architectures. The new helper's stream-
>> lined interface enables more refactoring within fbdev's mmap
>> implementation.
>>
>> [...]
> 
> Patches 3-5 applied to powerpc/fixes.
> 
> [3/5] arch/powerpc: Remove trailing whitespaces
>        https://git.kernel.org/powerpc/c/322948c3198cf80e7c10d953ddad24ebd85757cd
> [4/5] arch/powerpc: Remove file parameter from phys_mem_access_prot code
>        https://git.kernel.org/powerpc/c/1f92a844c35e483c00bab8a7b7d39c555ee799d8
> [5/5] arch/powerpc: Call internal __phys_mem_access_prot() in fbdev code
>        https://git.kernel.org/powerpc/c/deebe5f607d7f72f83c41163191ad0c1c4356385

Great, thanks a lot!

> 
> cheers