mbox series

[v2,0/5] virtio-gpu: add blob migration support

Message ID 20230907130936.767722-1-marcandre.lureau@redhat.com
Headers show
Series virtio-gpu: add blob migration support | expand

Message

Marc-André Lureau Sept. 7, 2023, 1:09 p.m. UTC
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Hi,

This is a follow-up of the previous patch "[PATCH] virtio-gpu: block migration
of VMs with blob=true". Now that migration support is implemented, we can decide
to drop the migration blocker patch, or apply and revert it, so that
backporting of a quick fix is made easier.

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2236353

Marc-André Lureau (5):
  virtio-gpu: block migration of VMs with blob=true
  virtio-gpu: factor out restore mapping
  virtio-gpu: move scanout restoration to post_load
  virtio-gpu: add virtio-gpu/blob vmstate subsection
  Revert "virtio-gpu: block migration of VMs with blob=true"

 hw/display/virtio-gpu.c | 174 +++++++++++++++++++++++++++++++++-------
 1 file changed, 146 insertions(+), 28 deletions(-)

Comments

Marc-André Lureau Sept. 19, 2023, 12:51 p.m. UTC | #1
Hi

On Thu, Sep 7, 2023 at 5:15 PM <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Hi,
>
> This is a follow-up of the previous patch "[PATCH] virtio-gpu: block migration
> of VMs with blob=true". Now that migration support is implemented, we can decide
> to drop the migration blocker patch, or apply and revert it, so that
> backporting of a quick fix is made easier.
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=2236353
>
> Marc-André Lureau (5):
>   virtio-gpu: block migration of VMs with blob=true
>   virtio-gpu: factor out restore mapping
>   virtio-gpu: move scanout restoration to post_load
>   virtio-gpu: add virtio-gpu/blob vmstate subsection
>   Revert "virtio-gpu: block migration of VMs with blob=true"
>
>  hw/display/virtio-gpu.c | 174 +++++++++++++++++++++++++++++++++-------
>  1 file changed, 146 insertions(+), 28 deletions(-)
>
> --
> 2.41.0
>

ping
Peter Xu Sept. 19, 2023, 3:09 p.m. UTC | #2
On Tue, Sep 19, 2023 at 04:51:21PM +0400, Marc-André Lureau wrote:
> Hi
> 
> On Thu, Sep 7, 2023 at 5:15 PM <marcandre.lureau@redhat.com> wrote:
> >
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > Hi,
> >
> > This is a follow-up of the previous patch "[PATCH] virtio-gpu: block migration
> > of VMs with blob=true". Now that migration support is implemented, we can decide
> > to drop the migration blocker patch, or apply and revert it, so that
> > backporting of a quick fix is made easier.
> >
> > Fixes:
> > https://bugzilla.redhat.com/show_bug.cgi?id=2236353
> >
> > Marc-André Lureau (5):
> >   virtio-gpu: block migration of VMs with blob=true
> >   virtio-gpu: factor out restore mapping
> >   virtio-gpu: move scanout restoration to post_load
> >   virtio-gpu: add virtio-gpu/blob vmstate subsection
> >   Revert "virtio-gpu: block migration of VMs with blob=true"
> >
> >  hw/display/virtio-gpu.c | 174 +++++++++++++++++++++++++++++++++-------
> >  1 file changed, 146 insertions(+), 28 deletions(-)

For migration:

Acked-by: Peter Xu <peterx@redhat.com>
Marc-André Lureau Nov. 6, 2023, 10:44 a.m. UTC | #3
Hi

On Tue, Sep 19, 2023 at 7:09 PM Peter Xu <peterx@redhat.com> wrote:
>
> On Tue, Sep 19, 2023 at 04:51:21PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Thu, Sep 7, 2023 at 5:15 PM <marcandre.lureau@redhat.com> wrote:
> > >
> > > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> > >
> > > Hi,
> > >
> > > This is a follow-up of the previous patch "[PATCH] virtio-gpu: block migration
> > > of VMs with blob=true". Now that migration support is implemented, we can decide
> > > to drop the migration blocker patch, or apply and revert it, so that
> > > backporting of a quick fix is made easier.
> > >
> > > Fixes:
> > > https://bugzilla.redhat.com/show_bug.cgi?id=2236353
> > >
> > > Marc-André Lureau (5):
> > >   virtio-gpu: block migration of VMs with blob=true
> > >   virtio-gpu: factor out restore mapping
> > >   virtio-gpu: move scanout restoration to post_load
> > >   virtio-gpu: add virtio-gpu/blob vmstate subsection
> > >   Revert "virtio-gpu: block migration of VMs with blob=true"
> > >
> > >  hw/display/virtio-gpu.c | 174 +++++++++++++++++++++++++++++++++-------
> > >  1 file changed, 146 insertions(+), 28 deletions(-)
>
> For migration:
>
> Acked-by: Peter Xu <peterx@redhat.com>
>

Anyone else to check this series? Laszlo perhaps?

Or should I just send it as part of the next gpu-stuff PR?

thanks
Laszlo Ersek Nov. 7, 2023, 12:21 p.m. UTC | #4
On 11/6/23 11:44, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Sep 19, 2023 at 7:09 PM Peter Xu <peterx@redhat.com> wrote:
>>
>> On Tue, Sep 19, 2023 at 04:51:21PM +0400, Marc-André Lureau wrote:
>>> Hi
>>>
>>> On Thu, Sep 7, 2023 at 5:15 PM <marcandre.lureau@redhat.com> wrote:
>>>>
>>>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>>>
>>>> Hi,
>>>>
>>>> This is a follow-up of the previous patch "[PATCH] virtio-gpu: block migration
>>>> of VMs with blob=true". Now that migration support is implemented, we can decide
>>>> to drop the migration blocker patch, or apply and revert it, so that
>>>> backporting of a quick fix is made easier.
>>>>
>>>> Fixes:
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=2236353
>>>>
>>>> Marc-André Lureau (5):
>>>>   virtio-gpu: block migration of VMs with blob=true
>>>>   virtio-gpu: factor out restore mapping
>>>>   virtio-gpu: move scanout restoration to post_load
>>>>   virtio-gpu: add virtio-gpu/blob vmstate subsection
>>>>   Revert "virtio-gpu: block migration of VMs with blob=true"
>>>>
>>>>  hw/display/virtio-gpu.c | 174 +++++++++++++++++++++++++++++++++-------
>>>>  1 file changed, 146 insertions(+), 28 deletions(-)
>>
>> For migration:
>>
>> Acked-by: Peter Xu <peterx@redhat.com>
>>
> 
> Anyone else to check this series? Laszlo perhaps?

Sorry, I don't have the patches, plus I'm already loaded with other
reviews elsehwere :/

> Or should I just send it as part of the next gpu-stuff PR?

You appear to have an ACK from Peter; I'd say run with it. Gerd is on CC
so I'm comfortable saying this.

Laszlo