diff mbox series

[1/4] ui/console: make qemu_console_is_multihead() static

Message ID 20230913144959.41891-2-lersek@redhat.com
State New
Headers show
Series ui/console: multihead: fix crash, simplify logic | expand

Commit Message

Laszlo Ersek Sept. 13, 2023, 2:49 p.m. UTC 
qemu_console_is_multihead() is only called from within "ui/console.c";
make it static.

Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com> (odd fixer:Graphics)
Cc: Gerd Hoffmann <kraxel@redhat.com> (odd fixer:Graphics)
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 include/ui/console.h | 1 -
 ui/console.c         | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

Comments

Philippe Mathieu-Daudé Sept. 13, 2023, 3:12 p.m. UTC | #1 
On 13/9/23 16:49, Laszlo Ersek wrote:
> qemu_console_is_multihead() is only called from within "ui/console.c";
> make it static.
> 
> Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com> (odd fixer:Graphics)
> Cc: Gerd Hoffmann <kraxel@redhat.com> (odd fixer:Graphics)
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>   include/ui/console.h | 1 -
>   ui/console.c         | 2 +-
>   2 files changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/include/ui/console.h b/include/ui/console.h
index 1ccd432b4d64..d715f88b1be2 100644
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -506,7 +506,6 @@  bool qemu_console_is_visible(QemuConsole *con);
 bool qemu_console_is_graphic(QemuConsole *con);
 bool qemu_console_is_fixedsize(QemuConsole *con);
 bool qemu_console_is_gl_blocked(QemuConsole *con);
-bool qemu_console_is_multihead(DeviceState *dev);
 char *qemu_console_get_label(QemuConsole *con);
 int qemu_console_get_index(QemuConsole *con);
 uint32_t qemu_console_get_head(QemuConsole *con);
diff --git a/ui/console.c b/ui/console.c
index e4d61794bb2c..adacc3473140 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -2365,7 +2365,7 @@  bool qemu_console_is_gl_blocked(QemuConsole *con)
     return con->gl_block;
 }
 
-bool qemu_console_is_multihead(DeviceState *dev)
+static bool qemu_console_is_multihead(DeviceState *dev)
 {
     QemuConsole *con;
     Object *obj;