| Message ID | 20230825033619.2075837-1-zhao1.liu@linux.intel.com |
|---|---|
| Headers | show |
| Series | tests: Add CPU topology related smbios test cases | expand |
25.08.2023 06:36, Zhao Liu wrote: > From: Zhao Liu <zhao1.liu@intel.com> > > Hi all, > > This patchset is the follow up tests of previous topology fixes in > smbios [1]. > > In this patchset, add these test cases: > > 1. Add the case to test 2 newly added topology helpers (patch 1): > * machine_topo_get_cores_per_socket() > * machine_topo_get_threads_per_socket() > > 2. Add the cases in bios-tables-test.c to: > * test smbios type4 table count (patch 2-4). > * test smbios type4 core count field (patch 5-7). > * update the test of smbios type4 core count2 field (patch 8-10). > * test smbios type4 thread count (patch 11-13). > * test smbios type4 thread count2 (patch 14-16). > > With the above new cases, cover all commits of [1] in test. > > [1]: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg06225.html Hmm. I definitely didn't expect such a large patchset.. I asked for just a small, maybe manual (from command-line) reproducer of the original issue, so I can verify it is fixed before applying the change in question to qemu stable trees. It is a large work. Lemme at least give it a try in the gitlab CI... Philippe, can you pick this up for the misc tree? /mjt
Hi Michael, On Fri, Sep 01, 2023 at 12:55:33PM +0300, Michael Tokarev wrote: > Date: Fri, 1 Sep 2023 12:55:33 +0300 > From: Michael Tokarev <mjt@tls.msk.ru> > Subject: Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases > > 25.08.2023 06:36, Zhao Liu wrote: > > From: Zhao Liu <zhao1.liu@intel.com> > > > > Hi all, > > > > This patchset is the follow up tests of previous topology fixes in > > smbios [1]. > > > > In this patchset, add these test cases: > > > > 1. Add the case to test 2 newly added topology helpers (patch 1): > > * machine_topo_get_cores_per_socket() > > * machine_topo_get_threads_per_socket() > > > > 2. Add the cases in bios-tables-test.c to: > > * test smbios type4 table count (patch 2-4). > > * test smbios type4 core count field (patch 5-7). > > * update the test of smbios type4 core count2 field (patch 8-10). > > * test smbios type4 thread count (patch 11-13). > > * test smbios type4 thread count2 (patch 14-16). > > > > With the above new cases, cover all commits of [1] in test. > > > > [1]: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg06225.html > > Hmm. I definitely didn't expect such a large patchset.. I asked for just > a small, maybe manual (from command-line) reproducer of the original issue, > so I can verify it is fixed before applying the change in question to qemu > stable trees. Since these issues are found by coding reading, they are "byproducts" of other topology-related work I've been woring on, not directly identified by any anomaly... ...So I'm not quite sure what the consequences of these few misuses of topology fields are, and how they might manifest themselves. > It is a large work. Lemme at least give it a try in the > gitlab CI... The test cases are the ones that clearly define the relevant topology issues. Thanks, Zhao > > Philippe, can you pick this up for the misc tree? > > /mjt
On 1/9/23 11:55, Michael Tokarev wrote: > 25.08.2023 06:36, Zhao Liu wrote: >> From: Zhao Liu <zhao1.liu@intel.com> >> >> Hi all, >> >> This patchset is the follow up tests of previous topology fixes in >> smbios [1]. >> >> In this patchset, add these test cases: >> >> 1. Add the case to test 2 newly added topology helpers (patch 1): >> * machine_topo_get_cores_per_socket() >> * machine_topo_get_threads_per_socket() >> >> 2. Add the cases in bios-tables-test.c to: >> * test smbios type4 table count (patch 2-4). >> * test smbios type4 core count field (patch 5-7). >> * update the test of smbios type4 core count2 field (patch 8-10). >> * test smbios type4 thread count (patch 11-13). >> * test smbios type4 thread count2 (patch 14-16). >> >> With the above new cases, cover all commits of [1] in test. >> >> [1]: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg06225.html > > Hmm. I definitely didn't expect such a large patchset.. I asked for just > a small, maybe manual (from command-line) reproducer of the original issue, > so I can verify it is fixed before applying the change in question to qemu > stable trees. It is a large work. Lemme at least give it a try in the > gitlab CI... > > Philippe, can you pick this up for the misc tree? This area have well defined maintainers: $ ./scripts/get_maintainer.pl -f tests/data/acpi/ "Michael S. Tsirkin" <mst@redhat.com> (supporter:ACPI/SMBIOS) Igor Mammedov <imammedo@redhat.com> (supporter:ACPI/SMBIOS) Ani Sinha <anisinha@redhat.com> (reviewer:ACPI/SMBIOS) So I'll pass ;)
On Tue, Sep 05, 2023 at 02:56:46PM +0800, Zhao Liu wrote: > Hi Michael, > > On Fri, Sep 01, 2023 at 12:55:33PM +0300, Michael Tokarev wrote: > > Date: Fri, 1 Sep 2023 12:55:33 +0300 > > From: Michael Tokarev <mjt@tls.msk.ru> > > Subject: Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases > > > > 25.08.2023 06:36, Zhao Liu wrote: > > > From: Zhao Liu <zhao1.liu@intel.com> > > > > > > Hi all, > > > > > > This patchset is the follow up tests of previous topology fixes in > > > smbios [1]. > > > > > > In this patchset, add these test cases: > > > > > > 1. Add the case to test 2 newly added topology helpers (patch 1): > > > * machine_topo_get_cores_per_socket() > > > * machine_topo_get_threads_per_socket() > > > > > > 2. Add the cases in bios-tables-test.c to: > > > * test smbios type4 table count (patch 2-4). > > > * test smbios type4 core count field (patch 5-7). > > > * update the test of smbios type4 core count2 field (patch 8-10). > > > * test smbios type4 thread count (patch 11-13). > > > * test smbios type4 thread count2 (patch 14-16). > > > > > > With the above new cases, cover all commits of [1] in test. > > > > > > [1]: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg06225.html > > > > Hmm. I definitely didn't expect such a large patchset.. I asked for just > > a small, maybe manual (from command-line) reproducer of the original issue, > > so I can verify it is fixed before applying the change in question to qemu > > stable trees. > > Since these issues are found by coding reading, they are "byproducts" of > other topology-related work I've been woring on, not directly identified > by any anomaly... > > ...So I'm not quite sure what the consequences of these few misuses of > topology fields are, and how they might manifest themselves. > > > It is a large work. Lemme at least give it a try in the > > gitlab CI... > > The test cases are the ones that clearly define the relevant topology > issues. > > > Thanks, > Zhao I think it's ok, as long as Igor's happy. > > > > Philippe, can you pick this up for the misc tree? > > > > /mjt
On Fri, 15 Sep 2023 09:48:08 -0400 "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Tue, Sep 05, 2023 at 02:56:46PM +0800, Zhao Liu wrote: > > Hi Michael, > > > > On Fri, Sep 01, 2023 at 12:55:33PM +0300, Michael Tokarev wrote: > > > Date: Fri, 1 Sep 2023 12:55:33 +0300 > > > From: Michael Tokarev <mjt@tls.msk.ru> > > > Subject: Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases > > > > > > 25.08.2023 06:36, Zhao Liu wrote: > > > > From: Zhao Liu <zhao1.liu@intel.com> > > > > > > > > Hi all, > > > > > > > > This patchset is the follow up tests of previous topology fixes in > > > > smbios [1]. > > > > > > > > In this patchset, add these test cases: > > > > > > > > 1. Add the case to test 2 newly added topology helpers (patch 1): > > > > * machine_topo_get_cores_per_socket() > > > > * machine_topo_get_threads_per_socket() > > > > > > > > 2. Add the cases in bios-tables-test.c to: > > > > * test smbios type4 table count (patch 2-4). > > > > * test smbios type4 core count field (patch 5-7). > > > > * update the test of smbios type4 core count2 field (patch 8-10). > > > > * test smbios type4 thread count (patch 11-13). > > > > * test smbios type4 thread count2 (patch 14-16). > > > > > > > > With the above new cases, cover all commits of [1] in test. > > > > > > > > [1]: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg06225.html > > > > > > Hmm. I definitely didn't expect such a large patchset.. I asked for just > > > a small, maybe manual (from command-line) reproducer of the original issue, > > > so I can verify it is fixed before applying the change in question to qemu > > > stable trees. > > > > Since these issues are found by coding reading, they are "byproducts" of > > other topology-related work I've been woring on, not directly identified > > by any anomaly... > > > > ...So I'm not quite sure what the consequences of these few misuses of > > topology fields are, and how they might manifest themselves. > > > > > It is a large work. Lemme at least give it a try in the > > > gitlab CI... > > > > The test cases are the ones that clearly define the relevant topology > > issues. > > > > > > Thanks, > > Zhao > > I think it's ok, as long as Igor's happy. series looks fine to me (modulo cosmetic issues and better commit messages as noted in per patch review) > > > > > > > Philippe, can you pick this up for the misc tree? > > > > > > /mjt >
On Fri, Sep 15, 2023 at 04:30:55PM +0200, Igor Mammedov wrote: > Date: Fri, 15 Sep 2023 16:30:55 +0200 > From: Igor Mammedov <imammedo@redhat.com> > Subject: Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases > X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) > > On Fri, 15 Sep 2023 09:48:08 -0400 > "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > On Tue, Sep 05, 2023 at 02:56:46PM +0800, Zhao Liu wrote: > > > Hi Michael, > > > > > > On Fri, Sep 01, 2023 at 12:55:33PM +0300, Michael Tokarev wrote: > > > > Date: Fri, 1 Sep 2023 12:55:33 +0300 > > > > From: Michael Tokarev <mjt@tls.msk.ru> > > > > Subject: Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases > > > > > > > > 25.08.2023 06:36, Zhao Liu wrote: > > > > > From: Zhao Liu <zhao1.liu@intel.com> > > > > > > > > > > Hi all, > > > > > > > > > > This patchset is the follow up tests of previous topology fixes in > > > > > smbios [1]. > > > > > > > > > > In this patchset, add these test cases: > > > > > > > > > > 1. Add the case to test 2 newly added topology helpers (patch 1): > > > > > * machine_topo_get_cores_per_socket() > > > > > * machine_topo_get_threads_per_socket() > > > > > > > > > > 2. Add the cases in bios-tables-test.c to: > > > > > * test smbios type4 table count (patch 2-4). > > > > > * test smbios type4 core count field (patch 5-7). > > > > > * update the test of smbios type4 core count2 field (patch 8-10). > > > > > * test smbios type4 thread count (patch 11-13). > > > > > * test smbios type4 thread count2 (patch 14-16). > > > > > > > > > > With the above new cases, cover all commits of [1] in test. > > > > > > > > > > [1]: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg06225.html > > > > > > > > Hmm. I definitely didn't expect such a large patchset.. I asked for just > > > > a small, maybe manual (from command-line) reproducer of the original issue, > > > > so I can verify it is fixed before applying the change in question to qemu > > > > stable trees. > > > > > > Since these issues are found by coding reading, they are "byproducts" of > > > other topology-related work I've been woring on, not directly identified > > > by any anomaly... > > > > > > ...So I'm not quite sure what the consequences of these few misuses of > > > topology fields are, and how they might manifest themselves. > > > > > > > It is a large work. Lemme at least give it a try in the > > > > gitlab CI... > > > > > > The test cases are the ones that clearly define the relevant topology > > > issues. > > > > > > > > > Thanks, > > > Zhao > > > > I think it's ok, as long as Igor's happy. > > series looks fine to me > (modulo cosmetic issues and better commit messages as noted in per patch review) Thanks Igor! -Zhao > > > > > > > > > > > Philippe, can you pick this up for the misc tree? > > > > > > > > /mjt > > >
From: Zhao Liu <zhao1.liu@intel.com> Hi all, This patchset is the follow up tests of previous topology fixes in smbios [1]. In this patchset, add these test cases: 1. Add the case to test 2 newly added topology helpers (patch 1): * machine_topo_get_cores_per_socket() * machine_topo_get_threads_per_socket() 2. Add the cases in bios-tables-test.c to: * test smbios type4 table count (patch 2-4). * test smbios type4 core count field (patch 5-7). * update the test of smbios type4 core count2 field (patch 8-10). * test smbios type4 thread count (patch 11-13). * test smbios type4 thread count2 (patch 14-16). With the above new cases, cover all commits of [1] in test. [1]: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg06225.html Regards, Zhao --- Zhao Liu (16): tests: test-smp-parse: Add the test for cores/threads per socket helpers tests: bios-tables-test: Prepare the ACPI table change for type4 count test tests: bios-tables-test: Add test for smbios type4 count tests: bios-tables-test: Add ACPI table binaries for type4 count test tests: bios-tables-test: Prepare the ACPI table change for type4 core count test tests: bios-tables-test: Add test for smbios type4 core count tests: bios-tables-test: Add ACPI table binaries for type4 core count test tests: bios-tables-test: Prepare the ACPI table change for type4 core count2 test tests: bios-tables-test: Extend core count2 test to cover general topology tests: bios-tables-test: Update ACPI table binaries for core count2 test tests: bios-tables-test: Prepare the ACPI table change for type4 thread count test tests: bios-tables-test: Add test for smbios type4 thread count tests: bios-tables-test: Add ACPI table binaries for type4 thread count test tests: bios-tables-test: Prepare the ACPI table change for type4 thread count2 test tests: bios-tables-test: Add test for smbios type4 thread count2 tests: bios-tables-test: Add ACPI table binaries for type4 thread count2 test tests/data/acpi/q35/APIC.core-count | Bin 0 -> 544 bytes tests/data/acpi/q35/APIC.core-count2 | Bin 2478 -> 3238 bytes tests/data/acpi/q35/APIC.thread-count | Bin 0 -> 544 bytes tests/data/acpi/q35/APIC.thread-count2 | Bin 0 -> 7398 bytes tests/data/acpi/q35/APIC.type4-count | Bin 0 -> 1072 bytes tests/data/acpi/q35/DSDT.core-count | Bin 0 -> 12913 bytes tests/data/acpi/q35/DSDT.core-count2 | Bin 32495 -> 33770 bytes tests/data/acpi/q35/DSDT.thread-count | Bin 0 -> 12913 bytes tests/data/acpi/q35/DSDT.thread-count2 | Bin 0 -> 63671 bytes tests/data/acpi/q35/DSDT.type4-count | Bin 0 -> 18589 bytes tests/data/acpi/q35/FACP.core-count | Bin 0 -> 244 bytes tests/data/acpi/q35/FACP.thread-count | Bin 0 -> 244 bytes tests/data/acpi/q35/FACP.thread-count2 | Bin 0 -> 244 bytes tests/data/acpi/q35/FACP.type4-count | Bin 0 -> 244 bytes tests/qtest/bios-tables-test.c | 118 ++++++++++++++++++++++++- tests/unit/test-smp-parse.c | 67 +++++++++++--- 16 files changed, 169 insertions(+), 16 deletions(-) create mode 100644 tests/data/acpi/q35/APIC.core-count create mode 100644 tests/data/acpi/q35/APIC.thread-count create mode 100644 tests/data/acpi/q35/APIC.thread-count2 create mode 100644 tests/data/acpi/q35/APIC.type4-count create mode 100644 tests/data/acpi/q35/DSDT.core-count create mode 100644 tests/data/acpi/q35/DSDT.thread-count create mode 100644 tests/data/acpi/q35/DSDT.thread-count2 create mode 100644 tests/data/acpi/q35/DSDT.type4-count create mode 100644 tests/data/acpi/q35/FACP.core-count create mode 100644 tests/data/acpi/q35/FACP.thread-count create mode 100644 tests/data/acpi/q35/FACP.thread-count2 create mode 100644 tests/data/acpi/q35/FACP.type4-count