diff mbox series

[RFC,1/7] include/sysemu/os-posix.h: move *daemonize* declaration together

Message ID 2321b2404d3bc9b12ac1605dd59b221f61e294b8.1691843673.git.mjt@tls.msk.ru
State New
Headers show
Series move softmmu options processing from os-posix.c to vl.c | expand

Commit Message

Michael Tokarev Aug. 12, 2023, 12:47 p.m. UTC 
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 include/sysemu/os-posix.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Eric Blake Aug. 15, 2023, 4:22 p.m. UTC | #1 
On Sat, Aug 12, 2023 at 03:47:55PM +0300, Michael Tokarev wrote:
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  include/sysemu/os-posix.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h
> index 1030d39904..65b9c94e91 100644
> --- a/include/sysemu/os-posix.h
> +++ b/include/sysemu/os-posix.h
> @@ -47,13 +47,12 @@ void os_set_line_buffering(void);
>  void os_setup_early_signal_handling(void);
>  void os_set_proc_name(const char *s);
>  void os_setup_signal_handling(void);
> +int os_set_daemonize(bool d);
> +bool is_daemonized(void);
>  void os_daemonize(void);
>  void os_setup_post(void);
>  int os_mlock(void);
>  
> -int os_set_daemonize(bool d);
> -bool is_daemonized(void);
> -
>  /**
>   * qemu_alloc_stack:
>   * @sz: pointer to a size_t holding the requested usable stack size
> -- 
> 2.39.2
> 
>
Michael Tokarev Sept. 1, 2023, 10:10 a.m. UTC | #2 
15.08.2023 19:22, Eric Blake wrote:
> On Sat, Aug 12, 2023 at 03:47:55PM +0300, Michael Tokarev wrote:
>> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>> ---
>>   include/sysemu/os-posix.h | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Eric, thank you very much for the review!
This is usually an ungrateful work.. :)

/mjt
diff mbox series

Patch

diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h
index 1030d39904..65b9c94e91 100644
--- a/include/sysemu/os-posix.h
+++ b/include/sysemu/os-posix.h
@@ -47,13 +47,12 @@  void os_set_line_buffering(void);
 void os_setup_early_signal_handling(void);
 void os_set_proc_name(const char *s);
 void os_setup_signal_handling(void);
+int os_set_daemonize(bool d);
+bool is_daemonized(void);
 void os_daemonize(void);
 void os_setup_post(void);
 int os_mlock(void);
 
-int os_set_daemonize(bool d);
-bool is_daemonized(void);
-
 /**
  * qemu_alloc_stack:
  * @sz: pointer to a size_t holding the requested usable stack size