| Message ID | 20230824221440.484675-12-dbarboza@ventanamicro.com |
|---|---|
| State | New |
| Headers | show |
| Series | riscv: 'max' CPU, detect user choice in TCG | expand |
On Thu, Aug 24, 2023 at 07:14:31PM -0300, Daniel Henrique Barboza wrote: > Add smoke tests to ensure that we'll not break the 'max' CPU type when > adding new ratified extensions to be enabled. I'm not really sure what this test proves other than we didn't remove the minimally supported set of extensions that opensbi requires to boot. The other opensbi tests appear to be ensuring boards can boot, rather than cpus. Thanks, drew > > Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> > Reviewed-by: Alistair Francis <alistair.francis@wdc.com> > --- > tests/avocado/riscv_opensbi.py | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/tests/avocado/riscv_opensbi.py b/tests/avocado/riscv_opensbi.py > index bfff9cc3c3..15fd57fe51 100644 > --- a/tests/avocado/riscv_opensbi.py > +++ b/tests/avocado/riscv_opensbi.py > @@ -61,3 +61,19 @@ def test_riscv64_virt(self): > :avocado: tags=machine:virt > """ > self.boot_opensbi() > + > + def test_riscv32_virt_maxcpu(self): > + """ > + :avocado: tags=arch:riscv32 > + :avocado: tags=machine:virt > + :avocado: tags=cpu:max > + """ > + self.boot_opensbi() > + > + def test_riscv64_virt_maxcpu(self): > + """ > + :avocado: tags=arch:riscv64 > + :avocado: tags=machine:virt > + :avocado: tags=cpu:max > + """ > + self.boot_opensbi() > -- > 2.41.0 > >
On 8/31/23 10:16, Andrew Jones wrote: > On Thu, Aug 24, 2023 at 07:14:31PM -0300, Daniel Henrique Barboza wrote: >> Add smoke tests to ensure that we'll not break the 'max' CPU type when >> adding new ratified extensions to be enabled. > > I'm not really sure what this test proves other than we didn't remove the > minimally supported set of extensions that opensbi requires to boot. The > other opensbi tests appear to be ensuring boards can boot, rather than > cpus. I added this test because the 'max' CPU takes extra steps to init (e.g. enabling a bunch of extensions) in comparison with the other CPUs. I agree that it would be better to add a Tux test like we already have for the rv32/rv64 CPUs to ensure that the CPU is able to boot up to prompt. I'll see if I can get that working and, in that case, we can ditch this test and use a TuxBoot test instead. Thanks, Daniel > > Thanks, > drew > >> >> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com> >> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> >> --- >> tests/avocado/riscv_opensbi.py | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/tests/avocado/riscv_opensbi.py b/tests/avocado/riscv_opensbi.py >> index bfff9cc3c3..15fd57fe51 100644 >> --- a/tests/avocado/riscv_opensbi.py >> +++ b/tests/avocado/riscv_opensbi.py >> @@ -61,3 +61,19 @@ def test_riscv64_virt(self): >> :avocado: tags=machine:virt >> """ >> self.boot_opensbi() >> + >> + def test_riscv32_virt_maxcpu(self): >> + """ >> + :avocado: tags=arch:riscv32 >> + :avocado: tags=machine:virt >> + :avocado: tags=cpu:max >> + """ >> + self.boot_opensbi() >> + >> + def test_riscv64_virt_maxcpu(self): >> + """ >> + :avocado: tags=arch:riscv64 >> + :avocado: tags=machine:virt >> + :avocado: tags=cpu:max >> + """ >> + self.boot_opensbi() >> -- >> 2.41.0 >> >>
diff --git a/tests/avocado/riscv_opensbi.py b/tests/avocado/riscv_opensbi.py index bfff9cc3c3..15fd57fe51 100644 --- a/tests/avocado/riscv_opensbi.py +++ b/tests/avocado/riscv_opensbi.py @@ -61,3 +61,19 @@ def test_riscv64_virt(self): :avocado: tags=machine:virt """ self.boot_opensbi() + + def test_riscv32_virt_maxcpu(self): + """ + :avocado: tags=arch:riscv32 + :avocado: tags=machine:virt + :avocado: tags=cpu:max + """ + self.boot_opensbi() + + def test_riscv64_virt_maxcpu(self): + """ + :avocado: tags=arch:riscv64 + :avocado: tags=machine:virt + :avocado: tags=cpu:max + """ + self.boot_opensbi()