| Message ID | 20230823044803.737175-1-mpe@ellerman.id.au (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fe32945203ffc8d6fed815f7ed7729219f8b0ab6 |
| Headers | show |
| Series | cxl: Drop unused detach_spa() | expand |
On Wed, 2023-08-23 at 14:48 +1000, Michael Ellerman wrote: > Clang warns: > drivers/misc/cxl/native.c:272:20: error: unused function > 'detach_spa' [-Werror,-Wunused-function] > > It was created as part of some refactoring in commit 05155772f642 > ("cxl: > Allocate and release the SPA with the AFU"), but has never been > called > in its current form. Drop it. > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Indeed it looks unused. Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
On Wed, 23 Aug 2023 14:48:03 +1000, Michael Ellerman wrote: > Clang warns: > drivers/misc/cxl/native.c:272:20: error: unused function 'detach_spa' [-Werror,-Wunused-function] > > It was created as part of some refactoring in commit 05155772f642 ("cxl: > Allocate and release the SPA with the AFU"), but has never been called > in its current form. Drop it. > > [...] Applied to powerpc/next. [1/1] cxl: Drop unused detach_spa() https://git.kernel.org/powerpc/c/fe32945203ffc8d6fed815f7ed7729219f8b0ab6 cheers
diff --git a/drivers/misc/cxl/native.c b/drivers/misc/cxl/native.c index 50b0c44bb8d7..fbe16a6ab7ad 100644 --- a/drivers/misc/cxl/native.c +++ b/drivers/misc/cxl/native.c @@ -269,11 +269,6 @@ static void attach_spa(struct cxl_afu *afu) cxl_p1n_write(afu, CXL_PSL_SPAP_An, spap); } -static inline void detach_spa(struct cxl_afu *afu) -{ - cxl_p1n_write(afu, CXL_PSL_SPAP_An, 0); -} - void cxl_release_spa(struct cxl_afu *afu) { if (afu->native->spa) {
Clang warns: drivers/misc/cxl/native.c:272:20: error: unused function 'detach_spa' [-Werror,-Wunused-function] It was created as part of some refactoring in commit 05155772f642 ("cxl: Allocate and release the SPA with the AFU"), but has never been called in its current form. Drop it. Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> --- drivers/misc/cxl/native.c | 5 ----- 1 file changed, 5 deletions(-)