| Message ID | 20230818033648.8326-20-akihiko.odaki@daynix.com |
|---|---|
| State | New |
| Headers | show |
| Series | plugins: Allow to read registers | expand |
On Fri Aug 18, 2023 at 1:36 PM AEST, Akihiko Odaki wrote: > GDB has XML support since 6.7 which was released in 2007. > It's time to remove support for old GDB versions without XML support. These 3 patches might be better to go ahead in a preparation series with "remove support for gdb 6.7" in the subject so people don't miss it. You could put a minimum version in docs/system/gdb.rst too. For the ppc part, Reviewed-by: Nicholas Piggin <npiggin@gmail.com> > > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> > --- > target/ppc/gdbstub.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c > index c86b7055ca..7e3b67a234 100644 > --- a/target/ppc/gdbstub.c > +++ b/target/ppc/gdbstub.c > @@ -54,12 +54,6 @@ static int ppc_gdb_register_len(int n) > case 0 ... 31: > /* gprs */ > return sizeof(target_ulong); > - case 32 ... 63: > - /* fprs */ > - if (gdb_has_xml) { > - return 0; > - } > - return 8; > case 66: > /* cr */ > case 69: > @@ -74,12 +68,6 @@ static int ppc_gdb_register_len(int n) > case 68: > /* ctr */ > return sizeof(target_ulong); > - case 70: > - /* fpscr */ > - if (gdb_has_xml) { > - return 0; > - } > - return sizeof(target_ulong); > default: > return 0; > }
diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c index c86b7055ca..7e3b67a234 100644 --- a/target/ppc/gdbstub.c +++ b/target/ppc/gdbstub.c @@ -54,12 +54,6 @@ static int ppc_gdb_register_len(int n) case 0 ... 31: /* gprs */ return sizeof(target_ulong); - case 32 ... 63: - /* fprs */ - if (gdb_has_xml) { - return 0; - } - return 8; case 66: /* cr */ case 69: @@ -74,12 +68,6 @@ static int ppc_gdb_register_len(int n) case 68: /* ctr */ return sizeof(target_ulong); - case 70: - /* fpscr */ - if (gdb_has_xml) { - return 0; - } - return sizeof(target_ulong); default: return 0; }
GDB has XML support since 6.7 which was released in 2007. It's time to remove support for old GDB versions without XML support. Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> --- target/ppc/gdbstub.c | 12 ------------ 1 file changed, 12 deletions(-)