Message ID | 20230817-ppc_xmon-v1-1-8cc2d51b9995@google.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 7f3c5d099b6f8452dc4dcfe4179ea48e6a13d0eb |
Headers | show |
Series | Revert "powerpc/xmon: Relax frame size for clang" | expand |
On Thu, Aug 17, 2023 at 11:11:56AM -0700, ndesaulniers@google.com wrote: > This reverts commit 9c87156cce5a63735d1218f0096a65c50a7a32aa. > > I have not been able to reproduce the reported -Wframe-larger-than= > warning (or disassembly) with clang-11 or clang-18. > > I don't know precisely when this was fixed in llvm, but it may be time > to revert this. > > Closes: https://github.com/ClangBuiltLinux/linux/issues/252 > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > arch/powerpc/xmon/Makefile | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/arch/powerpc/xmon/Makefile b/arch/powerpc/xmon/Makefile > index d334de392e6c..7705aa74a24d 100644 > --- a/arch/powerpc/xmon/Makefile > +++ b/arch/powerpc/xmon/Makefile > @@ -10,12 +10,6 @@ KCSAN_SANITIZE := n > # Disable ftrace for the entire directory > ccflags-remove-$(CONFIG_FUNCTION_TRACER) += $(CC_FLAGS_FTRACE) > > -ifdef CONFIG_CC_IS_CLANG > -# clang stores addresses on the stack causing the frame size to blow > -# out. See https://github.com/ClangBuiltLinux/linux/issues/252 > -KBUILD_CFLAGS += -Wframe-larger-than=4096 > -endif > - > ccflags-$(CONFIG_PPC64) := $(NO_MINIMAL_TOC) > > obj-y += xmon.o nonstdio.o spr_access.o xmon_bpts.o > > --- > base-commit: 16931859a6500d360b90aeacab3b505a3560a3ed > change-id: 20230817-ppc_xmon-d288d803610e > > Best regards, > -- > Nick Desaulniers <ndesaulniers@google.com> >
On Thu, 17 Aug 2023 11:11:56 -0700, ndesaulniers@google.com wrote: > This reverts commit 9c87156cce5a63735d1218f0096a65c50a7a32aa. > > I have not been able to reproduce the reported -Wframe-larger-than= > warning (or disassembly) with clang-11 or clang-18. > > I don't know precisely when this was fixed in llvm, but it may be time > to revert this. > > [...] Applied to powerpc/next. [1/1] Revert "powerpc/xmon: Relax frame size for clang" https://git.kernel.org/powerpc/c/7f3c5d099b6f8452dc4dcfe4179ea48e6a13d0eb cheers
diff --git a/arch/powerpc/xmon/Makefile b/arch/powerpc/xmon/Makefile index d334de392e6c..7705aa74a24d 100644 --- a/arch/powerpc/xmon/Makefile +++ b/arch/powerpc/xmon/Makefile @@ -10,12 +10,6 @@ KCSAN_SANITIZE := n # Disable ftrace for the entire directory ccflags-remove-$(CONFIG_FUNCTION_TRACER) += $(CC_FLAGS_FTRACE) -ifdef CONFIG_CC_IS_CLANG -# clang stores addresses on the stack causing the frame size to blow -# out. See https://github.com/ClangBuiltLinux/linux/issues/252 -KBUILD_CFLAGS += -Wframe-larger-than=4096 -endif - ccflags-$(CONFIG_PPC64) := $(NO_MINIMAL_TOC) obj-y += xmon.o nonstdio.o spr_access.o xmon_bpts.o
This reverts commit 9c87156cce5a63735d1218f0096a65c50a7a32aa. I have not been able to reproduce the reported -Wframe-larger-than= warning (or disassembly) with clang-11 or clang-18. I don't know precisely when this was fixed in llvm, but it may be time to revert this. Closes: https://github.com/ClangBuiltLinux/linux/issues/252 Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> --- arch/powerpc/xmon/Makefile | 6 ------ 1 file changed, 6 deletions(-) --- base-commit: 16931859a6500d360b90aeacab3b505a3560a3ed change-id: 20230817-ppc_xmon-d288d803610e Best regards,