| Message ID | 20230807212745.70151-4-ankit.kumar@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | hw/nvme: bug fixes and doc update | expand |
On Aug 8 02:57, Ankit Kumar wrote: > Add missing entry for pif ("protection information format"). > Protection information size can be 8 or 16 bytes, Update the pil entry > as per the NVM command set specification. > > Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com> > --- > docs/system/devices/nvme.rst | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/docs/system/devices/nvme.rst b/docs/system/devices/nvme.rst > index 2a3af268f7..30d46d9338 100644 > --- a/docs/system/devices/nvme.rst > +++ b/docs/system/devices/nvme.rst > @@ -271,9 +271,13 @@ The virtual namespace device supports DIF- and DIX-based protection information > > ``pil=UINT8`` (default: ``0``) > Controls the location of the protection information within the metadata. Set > - to ``1`` to transfer protection information as the first eight bytes of > - metadata. Otherwise, the protection information is transferred as the last > - eight bytes. > + to ``1`` to transfer protection information as the first bytes of metadata. > + Otherwise, the protection information is transferred as the last bytes of > + metadata. > + > +``pif=UINT8`` (default: ``0``) > + By default, the namespace device uses 16 bit guard protection information > + format. Set to ``2`` to enable 64 bit guard protection information format. > I'll add a small note that pif=1 (32b guard) is not supported. Thanks, Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
diff --git a/docs/system/devices/nvme.rst b/docs/system/devices/nvme.rst index 2a3af268f7..30d46d9338 100644 --- a/docs/system/devices/nvme.rst +++ b/docs/system/devices/nvme.rst @@ -271,9 +271,13 @@ The virtual namespace device supports DIF- and DIX-based protection information ``pil=UINT8`` (default: ``0``) Controls the location of the protection information within the metadata. Set - to ``1`` to transfer protection information as the first eight bytes of - metadata. Otherwise, the protection information is transferred as the last - eight bytes. + to ``1`` to transfer protection information as the first bytes of metadata. + Otherwise, the protection information is transferred as the last bytes of + metadata. + +``pif=UINT8`` (default: ``0``) + By default, the namespace device uses 16 bit guard protection information + format. Set to ``2`` to enable 64 bit guard protection information format. Virtualization Enhancements and SR-IOV (Experimental Support) -------------------------------------------------------------
Add missing entry for pif ("protection information format"). Protection information size can be 8 or 16 bytes, Update the pil entry as per the NVM command set specification. Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com> --- docs/system/devices/nvme.rst | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)