mbox series

[0/3] linux-user, configure: fix CPU canonicalization

Message ID 20230807094807.471646-1-pbonzini@redhat.com
Headers show
Series linux-user, configure: fix CPU canonicalization | expand

Message

Paolo Bonzini Aug. 7, 2023, 9:48 a.m. UTC 
The CPU model has to be canonicalized to what Meson wants in the cross
file, to what Linux uses for its asm-$ARCH directories, and to what
QEMU uses for its user-mode emulation host/$ARCH directories.  Do
all three in a single case statement, and check that the Linux and
QEMU directories actually exist.

At a small cost in repeated lines, this ensures that there are no hidden
ordering requirements between the case statements.  In particular, commit
89e5b7935e9 ("configure: Fix linux-user host detection for riscv64",
2023-08-06) broke ppc64le because it assigned host_arch based on a
non-canonicalized version of $cpu.

While doing this, I noticed that linux-user won't work on x32, alpha
and 32-bit s390 these days, due to missing common-user/ fragments.
The first two patches clean up the directories.

Paolo Bonzini (3):
  linux-user: fix detection for x32
  linux-user: cleanup unused linux-user/include/host directories
  configure: unify case statements for CPU canonicalization

 configure                                   | 157 +++++++++++---------
 linux-user/include/host/alpha/host-signal.h |  55 -------
 linux-user/include/host/s390/host-signal.h  | 138 -----------------
 linux-user/include/host/x32/host-signal.h   |   1 -
 4 files changed, 87 insertions(+), 264 deletions(-)
 delete mode 100644 linux-user/include/host/alpha/host-signal.h
 delete mode 100644 linux-user/include/host/s390/host-signal.h
 delete mode 100644 linux-user/include/host/x32/host-signal.h

Comments

Richard Henderson Aug. 7, 2023, 4:13 p.m. UTC | #1 
On 8/7/23 02:48, Paolo Bonzini wrote:
> Paolo Bonzini (3):
>    linux-user: fix detection for x32
>    linux-user: cleanup unused linux-user/include/host directories
>    configure: unify case statements for CPU canonicalization

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Thanks for cleaning this up.


r~