| Message ID | 20230803155010.11367-1-mario.limonciello@amd.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Upgrade the max value for "Processor Upgrade" to 0x50 | expand |
On 8/3/23 23:50, Mario Limonciello wrote: > SMBIOS 3.7 spec specifies new socket types that are not covered > by fwts. This fixes the below error on an AMD AM5 machine: > > ``` > dmicheck: Out of range value 0x49 (range allowed 0x01..0x48) while accessing entry 'Processor Information (Type 4)' @ 0x8856856c, field 'Processor Upgrade', offset 0x19 > ``` > > Link: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.pdf p57 > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > src/dmi/dmicheck/dmicheck.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c > index f7262b03..50082b24 100644 > --- a/src/dmi/dmicheck/dmicheck.c > +++ b/src/dmi/dmicheck/dmicheck.c > @@ -1410,7 +1410,7 @@ static void dmicheck_entry(fwts_framework *fw, > table, addr, "Status", 0x18); > dmi_reserved_bits_check(fw, table, addr, "Status", hdr, sizeof(uint8_t), 0x18, 3, 5); > dmi_reserved_bits_check(fw, table, addr, "Status", hdr, sizeof(uint8_t), 0x18, 7, 7); > - dmi_min_max_uint8_check(fw, table, addr, "Processor Upgrade", hdr, 0x19, 0x1, 0x48); > + dmi_min_max_uint8_check(fw, table, addr, "Processor Upgrade", hdr, 0x19, 0x1, 0x50); > if (hdr->length < 0x23) > break; > dmi_str_check(fw, table, addr, "Serial Number", hdr, 0x20); Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c index f7262b03..50082b24 100644 --- a/src/dmi/dmicheck/dmicheck.c +++ b/src/dmi/dmicheck/dmicheck.c @@ -1410,7 +1410,7 @@ static void dmicheck_entry(fwts_framework *fw, table, addr, "Status", 0x18); dmi_reserved_bits_check(fw, table, addr, "Status", hdr, sizeof(uint8_t), 0x18, 3, 5); dmi_reserved_bits_check(fw, table, addr, "Status", hdr, sizeof(uint8_t), 0x18, 7, 7); - dmi_min_max_uint8_check(fw, table, addr, "Processor Upgrade", hdr, 0x19, 0x1, 0x48); + dmi_min_max_uint8_check(fw, table, addr, "Processor Upgrade", hdr, 0x19, 0x1, 0x50); if (hdr->length < 0x23) break; dmi_str_check(fw, table, addr, "Serial Number", hdr, 0x20);
SMBIOS 3.7 spec specifies new socket types that are not covered by fwts. This fixes the below error on an AMD AM5 machine: ``` dmicheck: Out of range value 0x49 (range allowed 0x01..0x48) while accessing entry 'Processor Information (Type 4)' @ 0x8856856c, field 'Processor Upgrade', offset 0x19 ``` Link: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.pdf p57 Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- src/dmi/dmicheck/dmicheck.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)