| Message ID | 20230731080317.112658-3-akihiko.odaki@daynix.com |
|---|---|
| State | New |
| Headers | show |
| Series | linux-user: brk/mmap fixes | expand |
On 7/31/23 10:03, Akihiko Odaki wrote: > Later the returned value is compared with -1, and negated errno is not > expected. > > Fixes: 00faf08c95 ("linux-user: Don't use MAP_FIXED in do_brk()") > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> Reviewed-by: Helge Deller <deller@gmx.de> Helge > --- > linux-user/syscall.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 95727a816a..b9d2ec02f9 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -862,9 +862,9 @@ abi_long do_brk(abi_ulong brk_val) > */ > if (new_host_brk_page > brk_page) { > new_alloc_size = new_host_brk_page - brk_page; > - mapped_addr = get_errno(target_mmap(brk_page, new_alloc_size, > - PROT_READ|PROT_WRITE, > - MAP_ANON|MAP_PRIVATE, 0, 0)); > + mapped_addr = target_mmap(brk_page, new_alloc_size, > + PROT_READ|PROT_WRITE, > + MAP_ANON|MAP_PRIVATE, 0, 0); > } else { > new_alloc_size = 0; > mapped_addr = brk_page;
diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 95727a816a..b9d2ec02f9 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -862,9 +862,9 @@ abi_long do_brk(abi_ulong brk_val) */ if (new_host_brk_page > brk_page) { new_alloc_size = new_host_brk_page - brk_page; - mapped_addr = get_errno(target_mmap(brk_page, new_alloc_size, - PROT_READ|PROT_WRITE, - MAP_ANON|MAP_PRIVATE, 0, 0)); + mapped_addr = target_mmap(brk_page, new_alloc_size, + PROT_READ|PROT_WRITE, + MAP_ANON|MAP_PRIVATE, 0, 0); } else { new_alloc_size = 0; mapped_addr = brk_page;
Later the returned value is compared with -1, and negated errno is not expected. Fixes: 00faf08c95 ("linux-user: Don't use MAP_FIXED in do_brk()") Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> --- linux-user/syscall.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)