Message ID | 20230728142748.305341-4-thuth@redhat.com |
---|---|
State | New |
Headers | show |
Series | Use Clang for compiling in the 64-bit MSYS2 job | expand |
On 28/7/23 16:27, Thomas Huth wrote: > Clang complains: > > ../util/oslib-win32.c:483:56: error: omitting the parameter name in a > function definition is a C2x extension [-Werror,-Wc2x-extensions] > win32_close_exception_handler(struct _EXCEPTION_RECORD*, > ^ > > Fix it by adding parameter names. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > util/oslib-win32.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/util/oslib-win32.c b/util/oslib-win32.c > index 429542face..070bb455d3 100644 > --- a/util/oslib-win32.c > +++ b/util/oslib-win32.c > @@ -480,8 +480,8 @@ int qemu_bind_wrap(int sockfd, const struct sockaddr *addr, > } > > EXCEPTION_DISPOSITION > -win32_close_exception_handler(struct _EXCEPTION_RECORD*, > - void*, struct _CONTEXT*, void*) > +win32_close_exception_handler(struct _EXCEPTION_RECORD *exrec, > + void *ptr1, struct _CONTEXT *cntx, void *ptr2) Per https://learn.microsoft.com/en-us/cpp/c-runtime-library/except-handler3: -- >8 -- diff --git a/include/sysemu/os-win32.h b/include/sysemu/os-win32.h index 91aa0d7ec0..cb42508745 100644 --- a/include/sysemu/os-win32.h +++ b/include/sysemu/os-win32.h @@ -260,8 +260,9 @@ ssize_t qemu_recvfrom_wrap(int sockfd, void *buf, size_t len, int flags, struct sockaddr *addr, socklen_t *addrlen); EXCEPTION_DISPOSITION -win32_close_exception_handler(struct _EXCEPTION_RECORD*, void*, - struct _CONTEXT*, void*); +win32_close_exception_handler(struct _EXCEPTION_RECORD *exception_record, + void *registration, struct _CONTEXT *context, + void *dispatcher); void *qemu_win32_map_alloc(size_t size, HANDLE *h, Error **errp); void qemu_win32_map_free(void *ptr, HANDLE h, Error **errp); diff --git a/util/oslib-win32.c b/util/oslib-win32.c index 429542face..19a0ea7fbe 100644 --- a/util/oslib-win32.c +++ b/util/oslib-win32.c @@ -480,8 +480,9 @@ int qemu_bind_wrap(int sockfd, const struct sockaddr *addr, } EXCEPTION_DISPOSITION -win32_close_exception_handler(struct _EXCEPTION_RECORD*, - void*, struct _CONTEXT*, void*) +win32_close_exception_handler(struct _EXCEPTION_RECORD *exception_record, + void *registration, struct _CONTEXT *context, + void *dispatcher) { return EXCEPTION_EXECUTE_HANDLER; } --- Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/util/oslib-win32.c b/util/oslib-win32.c index 429542face..070bb455d3 100644 --- a/util/oslib-win32.c +++ b/util/oslib-win32.c @@ -480,8 +480,8 @@ int qemu_bind_wrap(int sockfd, const struct sockaddr *addr, } EXCEPTION_DISPOSITION -win32_close_exception_handler(struct _EXCEPTION_RECORD*, - void*, struct _CONTEXT*, void*) +win32_close_exception_handler(struct _EXCEPTION_RECORD *exrec, + void *ptr1, struct _CONTEXT *cntx, void *ptr2) { return EXCEPTION_EXECUTE_HANDLER; }
Clang complains: ../util/oslib-win32.c:483:56: error: omitting the parameter name in a function definition is a C2x extension [-Werror,-Wc2x-extensions] win32_close_exception_handler(struct _EXCEPTION_RECORD*, ^ Fix it by adding parameter names. Signed-off-by: Thomas Huth <thuth@redhat.com> --- util/oslib-win32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)