Message ID | 20230726030450.757462-3-chris@laplante.io |
---|---|
State | New |
Headers | show |
Series | Add nRF51 DETECT signal with test | expand |
On Wed, 26 Jul 2023 at 04:32, Chris Laplante <chris@laplante.io> wrote: > > Signed-off-by: Chris Laplante <chris@laplante.io> > --- > softmmu/qtest.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/softmmu/qtest.c b/softmmu/qtest.c > index f8d764b719..1c92e5a6a3 100644 > --- a/softmmu/qtest.c > +++ b/softmmu/qtest.c > @@ -365,6 +365,15 @@ void qtest_set_command_cb(bool (*pc_cb)(CharBackend *chr, gchar **words)) > process_command_cb = pc_cb; > } > > +static void qtest_install_gpio_out_intercept(DeviceState *dev, const char *name, int n) > +{ > + qemu_irq *disconnected = g_new0(qemu_irq, 1); > + qemu_irq icpt = qemu_allocate_irq(qtest_irq_handler, > + disconnected, n); > + > + *disconnected = qdev_intercept_gpio_out(dev, icpt,name, n); Missing space after comma. Otherwise Reviewed-by: Peter Maydell <peter.maydell@linaro.org> (If this is the only issue with the series I'll fix it when I pick it up, no need for a respin.) thanks -- PMM
diff --git a/softmmu/qtest.c b/softmmu/qtest.c index f8d764b719..1c92e5a6a3 100644 --- a/softmmu/qtest.c +++ b/softmmu/qtest.c @@ -365,6 +365,15 @@ void qtest_set_command_cb(bool (*pc_cb)(CharBackend *chr, gchar **words)) process_command_cb = pc_cb; } +static void qtest_install_gpio_out_intercept(DeviceState *dev, const char *name, int n) +{ + qemu_irq *disconnected = g_new0(qemu_irq, 1); + qemu_irq icpt = qemu_allocate_irq(qtest_irq_handler, + disconnected, n); + + *disconnected = qdev_intercept_gpio_out(dev, icpt,name, n); +} + static void qtest_process_command(CharBackend *chr, gchar **words) { const gchar *command; @@ -415,12 +424,7 @@ static void qtest_process_command(CharBackend *chr, gchar **words) if (words[0][14] == 'o') { int i; for (i = 0; i < ngl->num_out; ++i) { - qemu_irq *disconnected = g_new0(qemu_irq, 1); - qemu_irq icpt = qemu_allocate_irq(qtest_irq_handler, - disconnected, i); - - *disconnected = qdev_intercept_gpio_out(dev, icpt, - ngl->name, i); + qtest_install_gpio_out_intercept(dev, ngl->name, i); } } else { qemu_irq_intercept_in(ngl->in, qtest_irq_handler,
Signed-off-by: Chris Laplante <chris@laplante.io> --- softmmu/qtest.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)