| Message ID | 20230717182859.707658-7-berrange@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | tests: enable meson test timeouts to improve debuggability | expand |
On 17/07/2023 20.28, Daniel P. Berrangé wrote: > The pxe-test takes about 1 + 1/2 minutes in a --enable-debug > build. Bumping to 3 minutes will give more headroom. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/qtest/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > index 1070c6dc64..c6da428dc5 100644 > --- a/tests/qtest/meson.build > +++ b/tests/qtest/meson.build > @@ -4,6 +4,7 @@ slow_qtests = { > 'npcm7xx_pwm-test': 300, > 'qom-test' : 900, > 'test-hmp' : 240, > + 'pxe-test': 180, > } > > qtests_generic = [ Reviewed-by: Thomas Huth <thuth@redhat.com>
On 17/07/2023 20.28, Daniel P. Berrangé wrote: > The pxe-test takes about 1 + 1/2 minutes in a --enable-debug > build. Bumping to 3 minutes will give more headroom. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/qtest/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > index 1070c6dc64..c6da428dc5 100644 > --- a/tests/qtest/meson.build > +++ b/tests/qtest/meson.build > @@ -4,6 +4,7 @@ slow_qtests = { > 'npcm7xx_pwm-test': 300, > 'qom-test' : 900, > 'test-hmp' : 240, > + 'pxe-test': 180, > } By the way, pxe-test uses the boot_sector_test() function, and that already uses a timeout of 600 seconds ... so we maybe should use the same (or even slightly higher) timeout value here? Thomas
On Wed, Jul 19, 2023 at 03:26:11PM +0200, Thomas Huth wrote: > On 17/07/2023 20.28, Daniel P. Berrangé wrote: > > The pxe-test takes about 1 + 1/2 minutes in a --enable-debug > > build. Bumping to 3 minutes will give more headroom. > > > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > > --- > > tests/qtest/meson.build | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > > index 1070c6dc64..c6da428dc5 100644 > > --- a/tests/qtest/meson.build > > +++ b/tests/qtest/meson.build > > @@ -4,6 +4,7 @@ slow_qtests = { > > 'npcm7xx_pwm-test': 300, > > 'qom-test' : 900, > > 'test-hmp' : 240, > > + 'pxe-test': 180, > > } > > By the way, pxe-test uses the boot_sector_test() function, and that already > uses a timeout of 600 seconds ... so we maybe should use the same (or even > slightly higher) timeout value here? Your original change setting that 600 limit says: If QEMU has been compiled with the flags --enable-tcg-interpreter and --enable-debug, the guest is running incredibly slow. The pxe boot test can take up to 400 seconds when testing the pseries ppc64 machine. so yeah, we need to set the timeout for pxe-test to 600 seconds too. I guess likewise for other tests using boot_sector_test() function too. With regards, Daniel
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index 1070c6dc64..c6da428dc5 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -4,6 +4,7 @@ slow_qtests = { 'npcm7xx_pwm-test': 300, 'qom-test' : 900, 'test-hmp' : 240, + 'pxe-test': 180, } qtests_generic = [
The pxe-test takes about 1 + 1/2 minutes in a --enable-debug build. Bumping to 3 minutes will give more headroom. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- tests/qtest/meson.build | 1 + 1 file changed, 1 insertion(+)