Message ID | 20230716115801.1505288-1-mjt@tls.msk.ru |
---|---|
State | New |
Headers | show |
16.07.2023 14:57, Michael Tokarev пишет: > The following changes since commit 7d07a21ec003724475566073404c5893e36de5e5: > > tree-wide spelling fixes in comments and some messages: hw/9pfs (2023-07-16 13:59:17 +0300) > > are available in the Git repository at: > > https://gitlab.com/mjt0k/qemu.git/ tags/trivial-patches-pull > > for you to fetch changes up to 7d07a21ec003724475566073404c5893e36de5e5: > > tree-wide spelling fixes in comments and some messages: hw/9pfs (2023-07-16 13:59:17 +0300) > > ---------------------------------------------------------------- > trivial-patches for 2023-07-16 > > This contains a doc fix for riscv and reviewed spelling fixes. > ---------------------------------------------------------------- This meant to be a PULL request, not PATCH series.. :) Thanks, /mjt
On 16/7/23 13:57, Michael Tokarev wrote: > The following changes since commit 7d07a21ec003724475566073404c5893e36de5e5: > > tree-wide spelling fixes in comments and some messages: hw/9pfs (2023-07-16 13:59:17 +0300) > > are available in the Git repository at: > > https://gitlab.com/mjt0k/qemu.git/ tags/trivial-patches-pull > > for you to fetch changes up to 7d07a21ec003724475566073404c5893e36de5e5: > > tree-wide spelling fixes in comments and some messages: hw/9pfs (2023-07-16 13:59:17 +0300) > > ---------------------------------------------------------------- > trivial-patches for 2023-07-16 > > This contains a doc fix for riscv and reviewed spelling fixes. > ---------------------------------------------------------------- > > Daniel Henrique Barboza (1): > docs/system/target-riscv.rst: tidy CPU firmware section > > Michael Tokarev (5): > tree-wide spelling fixes in comments and some messages: migration/ > tree-wide spelling fixes in comments and some messages: s390x > tree-wide spelling fixes in comments and some messages: arm > tree-wide spelling fixes in comments and some messages: other > architectures > tree-wide spelling fixes in comments and some messages: hw/9pfs FYI patch subject is usually "subsystem: Topic", see https://www.qemu.org/docs/master/devel/submitting-a-patch.html#write-a-meaningful-commit-message: QEMU follows the usual standard for git commit messages: the first line (which becomes the email subject line) is “subsystem: single line summary of change”. (not really a cosmetics comment, but various developers have mail filters written using this pattern).
16.07.2023 18:58, Philippe Mathieu-Daudé wrote: ... >> Michael Tokarev (5): >> tree-wide spelling fixes in comments and some messages: migration/ >> tree-wide spelling fixes in comments and some messages: s390x >> tree-wide spelling fixes in comments and some messages: arm >> tree-wide spelling fixes in comments and some messages: other >> architectures >> tree-wide spelling fixes in comments and some messages: hw/9pfs > > FYI patch subject is usually "subsystem: Topic", see > https://www.qemu.org/docs/master/devel/submitting-a-patch.html#write-a-meaningful-commit-message: > > QEMU follows the usual standard for git commit messages: the first > line (which becomes the email subject line) is “subsystem: single > line summary of change”. Yes Philippe, I know. In this case though, it really is "tree-wide". I tried to group them by subsystem but it doesn't work that well. Especially having in mind how many changes there are (about 400 in total). This particular series is a pull request, not a review request (I just forgot to add --subject-prefix=PULL when generating this one). This is the changes which has been reviewed by at least one person, out of the other pile. The others are here, for example: https://lists.nongnu.org/archive/html/qemu-devel/2023-07/msg03006.html and see comments by Peter there: https://lists.nongnu.org/archive/html/qemu-devel/2023-07/msg03050.html My plan is to get the reviewed parts applied, and re-send the rest once again. This is a huge work already to create the changes to begin with, and to review them as well. The initial RFC: https://lists.nongnu.org/archive/html/qemu-devel/2023-07/msg02841.html > (not really a cosmetics comment, but various developers have mail > filters written using this pattern). It's hardly possible to reliable filter by subsystem, because there's no formal subsystems defined and the "subsystem:" prefix in emails is really arbitrary. /mjt
On 16/07/2023 14.05, Michael Tokarev wrote: > 16.07.2023 14:57, Michael Tokarev пишет: >> The following changes since commit 7d07a21ec003724475566073404c5893e36de5e5: >> >> tree-wide spelling fixes in comments and some messages: hw/9pfs >> (2023-07-16 13:59:17 +0300) >> >> are available in the Git repository at: >> >> https://gitlab.com/mjt0k/qemu.git/ tags/trivial-patches-pull >> >> for you to fetch changes up to 7d07a21ec003724475566073404c5893e36de5e5: >> >> tree-wide spelling fixes in comments and some messages: hw/9pfs >> (2023-07-16 13:59:17 +0300) >> >> ---------------------------------------------------------------- >> trivial-patches for 2023-07-16 >> >> This contains a doc fix for riscv and reviewed spelling fixes. >> ---------------------------------------------------------------- > > This meant to be a PULL request, not PATCH series.. :) I guess you have to resend with a PULL in the subject? Thomas
On Mon, 17 Jul 2023 at 10:50, Michael Tokarev <mjt@tls.msk.ru> wrote: > > 16.07.2023 18:58, Philippe Mathieu-Daudé wrote: > ... > >> Michael Tokarev (5): > >> tree-wide spelling fixes in comments and some messages: migration/ > >> tree-wide spelling fixes in comments and some messages: s390x > >> tree-wide spelling fixes in comments and some messages: arm > >> tree-wide spelling fixes in comments and some messages: other > >> architectures > >> tree-wide spelling fixes in comments and some messages: hw/9pfs > > > > FYI patch subject is usually "subsystem: Topic", see > > https://www.qemu.org/docs/master/devel/submitting-a-patch.html#write-a-meaningful-commit-message: > > > > QEMU follows the usual standard for git commit messages: the first > > line (which becomes the email subject line) is “subsystem: single > > line summary of change”. > > Yes Philippe, I know. In this case though, it really is "tree-wide". I tried > to group them by subsystem but it doesn't work that well. Especially having > in mind how many changes there are (about 400 in total). But you have the subsystem name, you just put it on the wrong end of the subject line. You could fix this up if you're going to send these as a pull request... thanks -- PMM