| Message ID | 20230428221240.2679194-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | da5311a4b852eaf2c0feac8b28884a8d8a801dfc |
| Headers | show |
| Series | powerpc: remove unneeded if-checks | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 6 jobs. |
Le 29/04/2023 à 00:12, Tom Rix a écrit : > For ppc64, gcc with W=1 reports > arch/powerpc/platforms/cell/spu_base.c:330:17: error: > suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 330 | ; > | ^ > arch/powerpc/platforms/cell/spu_base.c:333:17: error: > suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 333 | ; > | ^ > > These if-checks do not do anything so remove them. > > Signed-off-by: Tom Rix <trix@redhat.com> Fixes: 67207b9664a8 ("[PATCH] spufs: The SPU file system, base") Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu> > --- > arch/powerpc/platforms/cell/spu_base.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c > index 7bd0b563e163..dea6f0f25897 100644 > --- a/arch/powerpc/platforms/cell/spu_base.c > +++ b/arch/powerpc/platforms/cell/spu_base.c > @@ -326,12 +326,6 @@ spu_irq_class_1(int irq, void *data) > if (stat & CLASS1_STORAGE_FAULT_INTR) > __spu_trap_data_map(spu, dar, dsisr); > > - if (stat & CLASS1_LS_COMPARE_SUSPEND_ON_GET_INTR) > - ; > - > - if (stat & CLASS1_LS_COMPARE_SUSPEND_ON_PUT_INTR) > - ; > - > spu->class_1_dsisr = 0; > spu->class_1_dar = 0; >
On Sat, Apr 29, 2023, at 00:12, Tom Rix wrote: > For ppc64, gcc with W=1 reports > arch/powerpc/platforms/cell/spu_base.c:330:17: error: > suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 330 | ; > | ^ > arch/powerpc/platforms/cell/spu_base.c:333:17: error: > suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 333 | ; > | ^ > > These if-checks do not do anything so remove them. > > Signed-off-by: Tom Rix <trix@redhat.com> The original intention was to document that there are other flags that could be handled here, but clearly nobody is adding code to spufs, so there is no point in keeping that. Acked-by: Arnd Bergmann <arnd@arndb.de>
On Fri, 28 Apr 2023 18:12:40 -0400, Tom Rix wrote: > For ppc64, gcc with W=1 reports > arch/powerpc/platforms/cell/spu_base.c:330:17: error: > suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 330 | ; > | ^ > arch/powerpc/platforms/cell/spu_base.c:333:17: error: > suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 333 | ; > | ^ > > [...] Applied to powerpc/next. [1/1] powerpc: remove unneeded if-checks https://git.kernel.org/powerpc/c/da5311a4b852eaf2c0feac8b28884a8d8a801dfc cheers
diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c index 7bd0b563e163..dea6f0f25897 100644 --- a/arch/powerpc/platforms/cell/spu_base.c +++ b/arch/powerpc/platforms/cell/spu_base.c @@ -326,12 +326,6 @@ spu_irq_class_1(int irq, void *data) if (stat & CLASS1_STORAGE_FAULT_INTR) __spu_trap_data_map(spu, dar, dsisr); - if (stat & CLASS1_LS_COMPARE_SUSPEND_ON_GET_INTR) - ; - - if (stat & CLASS1_LS_COMPARE_SUSPEND_ON_PUT_INTR) - ; - spu->class_1_dsisr = 0; spu->class_1_dar = 0;
For ppc64, gcc with W=1 reports arch/powerpc/platforms/cell/spu_base.c:330:17: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] 330 | ; | ^ arch/powerpc/platforms/cell/spu_base.c:333:17: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] 333 | ; | ^ These if-checks do not do anything so remove them. Signed-off-by: Tom Rix <trix@redhat.com> --- arch/powerpc/platforms/cell/spu_base.c | 6 ------ 1 file changed, 6 deletions(-)