| Message ID | 20230609183238.1767186-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | be0f9ca024b3ae17fac6b15c04519840f3418269 |
| Headers | show |
| Series | powerpc: fsl_soc: Use of_range_to_resource() for "ranges" parsing | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_clang | fail | 2 of 6 jobs failed. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | fail | kernel (corenet32_smp_defconfig, fedora-37) failed at step Build. |
| snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | fail | sparse (mpc885_ads_defconfig, fedora-37, ppc64) failed at step Build. |
On Fri, 09 Jun 2023 12:32:38 -0600, Rob Herring wrote: > "ranges" is a standard property with common parsing functions. Users > shouldn't be implementing their own parsing of it. Refactor the FSL RapidIO > "ranges" parsing to use of_range_to_resource() instead. > > Applied to powerpc/next. [1/1] powerpc: fsl_soc: Use of_range_to_resource() for "ranges" parsing https://git.kernel.org/powerpc/c/be0f9ca024b3ae17fac6b15c04519840f3418269 cheers
diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c index 6ebbbca41065..68709743450e 100644 --- a/arch/powerpc/sysdev/fsl_soc.c +++ b/arch/powerpc/sysdev/fsl_soc.c @@ -51,18 +51,10 @@ phys_addr_t get_immrbase(void) soc = of_find_node_by_type(NULL, "soc"); if (soc) { - int size; - u32 naddr; - const __be32 *prop = of_get_property(soc, "#address-cells", &size); - - if (prop && size == 4) - naddr = be32_to_cpup(prop); - else - naddr = 2; - - prop = of_get_property(soc, "ranges", &size); - if (prop) - immrbase = of_translate_address(soc, prop + naddr); + struct resource res; + + if (!of_range_to_resource(soc, 0, &res)) + immrbase = res.start; of_node_put(soc); }
"ranges" is a standard property with common parsing functions. Users shouldn't be implementing their own parsing of it. Refactor the FSL RapidIO "ranges" parsing to use of_range_to_resource() instead. Signed-off-by: Rob Herring <robh@kernel.org> --- arch/powerpc/sysdev/fsl_soc.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-)