Message ID | 20230701054714.30512-1-rdunlap@infradead.org (mailing list archive) |
---|---|
State | Accepted |
Commit | 39f49684036d24af800ff194c33c7b2653c591d7 |
Headers | show |
Series | [v2] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y | expand |
Context | Check | Description |
---|---|---|
snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 6 jobs. |
Le 01/07/2023 à 07:47, Randy Dunlap a écrit : > In a randconfig with CONFIG_SERIAL_CPM=m and > CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error: > ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined! > > Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when > SERIAL_CPM=y. > > Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial ports.") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Kumar Gala <galak@kernel.crashing.org> > Cc: "Pali Rohár" <pali@kernel.org> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Nicholas Piggin <npiggin@gmail.com> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu> > Cc: linuxppc-dev@lists.ozlabs.org > Reviewed-by: Pali Rohár <pali@kernel.org> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu> > --- > v2: add Pali's R-b; > drop Scott Wood from Cc: list > > arch/powerpc/Kconfig.debug | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug > --- a/arch/powerpc/Kconfig.debug > +++ b/arch/powerpc/Kconfig.debug > @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x > > config PPC_EARLY_DEBUG_CPM > bool "Early serial debugging for Freescale CPM-based serial ports" > - depends on SERIAL_CPM > + depends on SERIAL_CPM=y > help > Select this to enable early debugging for Freescale chips > using a CPM-based serial port. This assumes that the bootwrapper
On Fri, 30 Jun 2023 22:47:12 -0700, Randy Dunlap wrote: > In a randconfig with CONFIG_SERIAL_CPM=m and > CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error: > ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined! > > Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when > SERIAL_CPM=y. > > [...] Applied to powerpc/next. [1/1] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y https://git.kernel.org/powerpc/c/39f49684036d24af800ff194c33c7b2653c591d7 cheers
diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug --- a/arch/powerpc/Kconfig.debug +++ b/arch/powerpc/Kconfig.debug @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x config PPC_EARLY_DEBUG_CPM bool "Early serial debugging for Freescale CPM-based serial ports" - depends on SERIAL_CPM + depends on SERIAL_CPM=y help Select this to enable early debugging for Freescale chips using a CPM-based serial port. This assumes that the bootwrapper