| Message ID | 20230629124500.1.I55e2f4e7903d686c4484cb23c033c6a9e1a9d4c4@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6cb44bef35ac11724ef22c5ae4f1bc607e2ef3d8 |
| Headers | show |
| Series | powerpc: Include asm/nmi.c in mobility.c for watchdog_hardlockup_set_timeout_pct() | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 6 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
On 6/29/23 12:45, Douglas Anderson wrote: > The powerpc/platforms/pseries/mobility.c calls > watchdog_hardlockup_set_timeout_pct(), which is declared in > <asm/nmi.h>. We used to automatically get <asm/nmi.h> included, but > that changed as of commit 7ca8fe94aa92 ("watchdog/hardlockup: define > HARDLOCKUP_DETECTOR_ARCH"). Let's add the explicit include. > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Closes: https://lore.kernel.org/r/af19b76d-aa4b-6c88-9cac-eae4b2072497@infradead.org > Fixes: 7ca8fe94aa92 ("watchdog/hardlockup: define HARDLOCKUP_DETECTOR_ARCH") > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Thanks. > --- > > arch/powerpc/platforms/pseries/mobility.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c > index cd632ba9ebff..0161226d8fec 100644 > --- a/arch/powerpc/platforms/pseries/mobility.c > +++ b/arch/powerpc/platforms/pseries/mobility.c > @@ -24,6 +24,7 @@ > #include <linux/stringify.h> > > #include <asm/machdep.h> > +#include <asm/nmi.h> > #include <asm/rtas.h> > #include "pseries.h" > #include "vas.h" /* vas_migration_handler() */
On Thu 2023-06-29 12:45:06, Douglas Anderson wrote: > The powerpc/platforms/pseries/mobility.c calls > watchdog_hardlockup_set_timeout_pct(), which is declared in > <asm/nmi.h>. We used to automatically get <asm/nmi.h> included, but > that changed as of commit 7ca8fe94aa92 ("watchdog/hardlockup: define > HARDLOCKUP_DETECTOR_ARCH"). Let's add the explicit include. > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Closes: https://lore.kernel.org/r/af19b76d-aa4b-6c88-9cac-eae4b2072497@infradead.org > Fixes: 7ca8fe94aa92 ("watchdog/hardlockup: define HARDLOCKUP_DETECTOR_ARCH") > Signed-off-by: Douglas Anderson <dianders@chromium.org> Thanks for the patch: Reviewed-by: Petr Mladek <pmladek@suse.com> Best Regards, Petr
On Thu, 29 Jun 2023 12:45:06 -0700, Douglas Anderson wrote: > The powerpc/platforms/pseries/mobility.c calls > watchdog_hardlockup_set_timeout_pct(), which is declared in > <asm/nmi.h>. We used to automatically get <asm/nmi.h> included, but > that changed as of commit 7ca8fe94aa92 ("watchdog/hardlockup: define > HARDLOCKUP_DETECTOR_ARCH"). Let's add the explicit include. > > > [...] Applied to powerpc/next. [1/1] powerpc: Include asm/nmi.c in mobility.c for watchdog_hardlockup_set_timeout_pct() https://git.kernel.org/powerpc/c/6cb44bef35ac11724ef22c5ae4f1bc607e2ef3d8 cheers
diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c index cd632ba9ebff..0161226d8fec 100644 --- a/arch/powerpc/platforms/pseries/mobility.c +++ b/arch/powerpc/platforms/pseries/mobility.c @@ -24,6 +24,7 @@ #include <linux/stringify.h> #include <asm/machdep.h> +#include <asm/nmi.h> #include <asm/rtas.h> #include "pseries.h" #include "vas.h" /* vas_migration_handler() */
The powerpc/platforms/pseries/mobility.c calls watchdog_hardlockup_set_timeout_pct(), which is declared in <asm/nmi.h>. We used to automatically get <asm/nmi.h> included, but that changed as of commit 7ca8fe94aa92 ("watchdog/hardlockup: define HARDLOCKUP_DETECTOR_ARCH"). Let's add the explicit include. Reported-by: Randy Dunlap <rdunlap@infradead.org> Closes: https://lore.kernel.org/r/af19b76d-aa4b-6c88-9cac-eae4b2072497@infradead.org Fixes: 7ca8fe94aa92 ("watchdog/hardlockup: define HARDLOCKUP_DETECTOR_ARCH") Signed-off-by: Douglas Anderson <dianders@chromium.org> --- arch/powerpc/platforms/pseries/mobility.c | 1 + 1 file changed, 1 insertion(+)