| Message ID | 787f5a712a0459bc21d83bb388770b58@208suo.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | cxl/ocxl: Possible repeated word | expand |
Hello, While the correction in the comment is of course ok, the patch was sent as html. You may want to check/fix how it was submitted. Fred On 18/06/2023 17:08, zhumao001@208suo.com wrote: > Delete repeated word in comment. Signed-off-by: Zhu Mao <zhumao001@ > 208suo. com> --- drivers/misc/cxl/native. c | 2 +- 1 file changed, 1 > insertion(+), 1 deletion(-) diff --git a/drivers/misc/cxl/native. c > b/drivers/misc/cxl/native. cindex > ZjQcmQRYFpfptBannerStart > This Message Is From an External Sender > This message came from outside your organization. > Report Suspicious > <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/PjiDSg!2k-hI76VihO6WgXx-IHFLxDVOAL2DdWMKjPu4ApiehtDXYjNrTR1Cj6nYDmD8SP9M8AZ7TpWUloL0Ixn_2IX60uI2MsuBkM$> > ZjQcmQRYFpfptBannerEnd > Delete repeated word in comment. > > Signed-off-by: Zhu Mao <zhumao001@208suo.com> > --- > drivers/misc/cxl/native.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/cxl/native.c b/drivers/misc/cxl/native.c > index 50b0c44bb8d7..6957946a6463 100644 > --- a/drivers/misc/cxl/native.c > +++ b/drivers/misc/cxl/native.c > @@ -920,7 +920,7 @@ int cxl_attach_dedicated_process_psl9(struct > cxl_context *ctx, u64 wed, u64 amr) > * Ideally we should do a wmb() here to make sure the changes to the > * PE are visible to the card before we call afu_enable. > * On ppc64 though all mmios are preceded by a 'sync' instruction > hence > - * we dont dont need one here. > + * we dont need one here. > */ > > result = cxl_ops->afu_reset(afu);
zhumao001@208suo.com writes: > Delete repeated word in comment. > > Signed-off-by: Zhu Mao <zhumao001@208suo.com> > --- > drivers/misc/cxl/native.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/cxl/native.c b/drivers/misc/cxl/native.c > index 50b0c44bb8d7..6957946a6463 100644 > --- a/drivers/misc/cxl/native.c > +++ b/drivers/misc/cxl/native.c > @@ -920,7 +920,7 @@ int cxl_attach_dedicated_process_psl9(struct > cxl_context *ctx, u64 wed, u64 amr) > * Ideally we should do a wmb() here to make sure the changes to > the > * PE are visible to the card before we call afu_enable. > * On ppc64 though all mmios are preceded by a 'sync' instruction > hence > - * we dont dont need one here. > + * we dont need one here. I know the rule is to only do one change per patch, but if you're fixing the wording of a comment you can absolutely fix the spelling at the same time. So please send a v2 with "dont" spelt correctly. cheers
diff --git a/drivers/misc/cxl/native.c b/drivers/misc/cxl/native.c index 50b0c44bb8d7..6957946a6463 100644 --- a/drivers/misc/cxl/native.c +++ b/drivers/misc/cxl/native.c @@ -920,7 +920,7 @@ int cxl_attach_dedicated_process_psl9(struct cxl_context *ctx, u64 wed, u64 amr) * Ideally we should do a wmb() here to make sure the changes to the * PE are visible to the card before we call afu_enable. * On ppc64 though all mmios are preceded by a 'sync' instruction hence - * we dont dont need one here. + * we dont need one here.
Delete repeated word in comment. Signed-off-by: Zhu Mao <zhumao001@208suo.com> --- drivers/misc/cxl/native.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) */ result = cxl_ops->afu_reset(afu);