| Message ID | 20230614140748.3584-1-ld.adecy@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Fix handling of AVR interrupts above 33. | expand |
On 14/6/23 16:07, Lucas Dietrich wrote: > This commit addresses a bug in the AVR interrupt handling code. > The modification involves replacing the usage of the ctz32 function > with ctz64 to ensure proper handling of interrupts above 33 in the AVR > target. > > Previously, timers 3, 4, and 5 interrupts were not functioning correctly > because most of their interrupt vectors are numbered above 33. > > Signed-off-by: Lucas Dietrich <ld.adecy@gmail.com> > --- > target/avr/helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks for insisting with the patch posting process :) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Michael Rolnik <mrolnik@gmail.com> On Wed, Jun 14, 2023 at 3:22 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote: > On 14/6/23 16:07, Lucas Dietrich wrote: > > This commit addresses a bug in the AVR interrupt handling code. > > The modification involves replacing the usage of the ctz32 function > > with ctz64 to ensure proper handling of interrupts above 33 in the AVR > > target. > > > > Previously, timers 3, 4, and 5 interrupts were not functioning correctly > > because most of their interrupt vectors are numbered above 33. > > > > Signed-off-by: Lucas Dietrich <ld.adecy@gmail.com> > > --- > > target/avr/helper.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Thanks for insisting with the patch posting process :) > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > >
Applied to the trivial tree, thank you! /mjt
On 18/6/23 08:56, Michael Tokarev wrote:
> Applied to the trivial tree, thank you!
Thanks. Do you mind updating the patch subject to:
"target/avr: Fix handling of interrupts above 33"?
diff --git a/target/avr/helper.c b/target/avr/helper.c index 2bad242a66..e6e7d51487 100644 --- a/target/avr/helper.c +++ b/target/avr/helper.c @@ -52,7 +52,7 @@ bool avr_cpu_exec_interrupt(CPUState *cs, int interrupt_request) } if (interrupt_request & CPU_INTERRUPT_HARD) { if (cpu_interrupts_enabled(env) && env->intsrc != 0) { - int index = ctz32(env->intsrc); + int index = ctz64(env->intsrc); cs->exception_index = EXCP_INT(index); avr_cpu_do_interrupt(cs); @@ -79,7 +79,7 @@ void avr_cpu_do_interrupt(CPUState *cs) if (cs->exception_index == EXCP_RESET) { vector = 0; } else if (env->intsrc != 0) { - vector = ctz32(env->intsrc) + 1; + vector = ctz64(env->intsrc) + 1; } if (avr_feature(env, AVR_FEATURE_3_BYTE_PC)) {
This commit addresses a bug in the AVR interrupt handling code. The modification involves replacing the usage of the ctz32 function with ctz64 to ensure proper handling of interrupts above 33 in the AVR target. Previously, timers 3, 4, and 5 interrupts were not functioning correctly because most of their interrupt vectors are numbered above 33. Signed-off-by: Lucas Dietrich <ld.adecy@gmail.com> --- target/avr/helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)