mbox series

[v2,0/2] Export struct ISAParallelState

Message ID 20230612081238.1742-1-shentey@gmail.com
Headers show
Series Export struct ISAParallelState | expand

Message

Bernhard Beschow June 12, 2023, 8:12 a.m. UTC 
This series incorporates rebased versions of the ISAParallelState patches of
[1] as requested by Mark.

v2:
* Add forgotten SoB tags (Zoltan, Phil)

Changes since [1]:
* Don't export register definitions (Phil)
* Rephrase commit message of second patch (Zoltan)

[1] https://patchew.org/QEMU/20230521123049.312349-1-shentey@gmail.com/

Bernhard Beschow (2):
  hw/char/parallel: Export struct ParallelState
  hw/char/parallel-isa: Export struct ISAParallelState

 include/hw/char/parallel-isa.h | 46 ++++++++++++++++++++++++++++++++++
 include/hw/char/parallel.h     | 21 +++++++++++++++-
 hw/char/parallel-isa.c         |  1 +
 hw/char/parallel.c             | 32 +----------------------
 hw/i386/pc_piix.c              |  2 +-
 hw/i386/pc_q35.c               |  2 +-
 hw/isa/isa-superio.c           |  1 +
 hw/sparc64/sun4u.c             |  2 +-
 8 files changed, 72 insertions(+), 35 deletions(-)
 create mode 100644 include/hw/char/parallel-isa.h

Comments

Mark Cave-Ayland June 12, 2023, 6:49 p.m. UTC | #1 
On 12/06/2023 09:12, Bernhard Beschow wrote:

> This series incorporates rebased versions of the ISAParallelState patches of
> [1] as requested by Mark.
> 
> v2:
> * Add forgotten SoB tags (Zoltan, Phil)
> 
> Changes since [1]:
> * Don't export register definitions (Phil)
> * Rephrase commit message of second patch (Zoltan)
> 
> [1] https://patchew.org/QEMU/20230521123049.312349-1-shentey@gmail.com/
> 
> Bernhard Beschow (2):
>    hw/char/parallel: Export struct ParallelState
>    hw/char/parallel-isa: Export struct ISAParallelState
> 
>   include/hw/char/parallel-isa.h | 46 ++++++++++++++++++++++++++++++++++
>   include/hw/char/parallel.h     | 21 +++++++++++++++-
>   hw/char/parallel-isa.c         |  1 +
>   hw/char/parallel.c             | 32 +----------------------
>   hw/i386/pc_piix.c              |  2 +-
>   hw/i386/pc_q35.c               |  2 +-
>   hw/isa/isa-superio.c           |  1 +
>   hw/sparc64/sun4u.c             |  2 +-
>   8 files changed, 72 insertions(+), 35 deletions(-)
>   create mode 100644 include/hw/char/parallel-isa.h

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.
Philippe Mathieu-Daudé June 13, 2023, 8:22 a.m. UTC | #2 
On 12/6/23 10:12, Bernhard Beschow wrote:
> This series incorporates rebased versions of the ISAParallelState patches of
> [1] as requested by Mark.

> Bernhard Beschow (2):
>    hw/char/parallel: Export struct ParallelState
>    hw/char/parallel-isa: Export struct ISAParallelState

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Philippe Mathieu-Daudé June 13, 2023, 9:32 a.m. UTC | #3 
On 12/6/23 10:12, Bernhard Beschow wrote:
> This series incorporates rebased versions of the ISAParallelState patches of
> [1] as requested by Mark.

> Bernhard Beschow (2):
>    hw/char/parallel: Export struct ParallelState
>    hw/char/parallel-isa: Export struct ISAParallelState

Thanks, queued (updating MAINTAINERS in patch 2).