| Message ID | 20230601163123.1805282-5-berrange@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | tests: enable meson test timeouts to improve debuggability | expand |
On 01/06/2023 18.31, Daniel P. Berrangé wrote: > On a reasonably modern laptop this test takes 40 seconds with the arm > emulator. Raising the timeout to 2 minutes gives greater headroom for > slowdown under GitLab CI. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/qtest/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > index 6943bbfdd5..d9fa30edbc 100644 > --- a/tests/qtest/meson.build > +++ b/tests/qtest/meson.build > @@ -1,4 +1,5 @@ > slow_qtests = { > + 'aspeed_smc-test': 120, > 'bios-tables-test' : 120, > 'migration-test' : 300, > 'npcm7xx_pwm-test': 150, Reviewed-by: Thomas Huth <thuth@redhat.com>
On 01/06/2023 18.31, Daniel P. Berrangé wrote: > On a reasonably modern laptop this test takes 40 seconds with the arm > emulator. Raising the timeout to 2 minutes gives greater headroom for > slowdown under GitLab CI. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/qtest/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > index 6943bbfdd5..d9fa30edbc 100644 > --- a/tests/qtest/meson.build > +++ b/tests/qtest/meson.build > @@ -1,4 +1,5 @@ > slow_qtests = { > + 'aspeed_smc-test': 120, > 'bios-tables-test' : 120, > 'migration-test' : 300, > 'npcm7xx_pwm-test': 150, I gave it a try in the CI and this one was failing for me: https://gitlab.com/thuth/qemu/-/jobs/4412460476 Looking at an earlier run, it needed 146 seconds to finish: https://gitlab.com/thuth/qemu/-/jobs/4411373417#L4954 Thomas
On Mon, Jun 05, 2023 at 01:31:36PM +0200, Thomas Huth wrote: > On 01/06/2023 18.31, Daniel P. Berrangé wrote: > > On a reasonably modern laptop this test takes 40 seconds with the arm > > emulator. Raising the timeout to 2 minutes gives greater headroom for > > slowdown under GitLab CI. > > > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > > --- > > tests/qtest/meson.build | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > > index 6943bbfdd5..d9fa30edbc 100644 > > --- a/tests/qtest/meson.build > > +++ b/tests/qtest/meson.build > > @@ -1,4 +1,5 @@ > > slow_qtests = { > > + 'aspeed_smc-test': 120, > > 'bios-tables-test' : 120, > > 'migration-test' : 300, > > 'npcm7xx_pwm-test': 150, > > I gave it a try in the CI and this one was failing for me: > > https://gitlab.com/thuth/qemu/-/jobs/4412460476 > > Looking at an earlier run, it needed 146 seconds to finish: > > https://gitlab.com/thuth/qemu/-/jobs/4411373417#L4954 Ok, lets make it 4 minutes then. With regards, Daniel
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index 6943bbfdd5..d9fa30edbc 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -1,4 +1,5 @@ slow_qtests = { + 'aspeed_smc-test': 120, 'bios-tables-test' : 120, 'migration-test' : 300, 'npcm7xx_pwm-test': 150,
On a reasonably modern laptop this test takes 40 seconds with the arm emulator. Raising the timeout to 2 minutes gives greater headroom for slowdown under GitLab CI. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- tests/qtest/meson.build | 1 + 1 file changed, 1 insertion(+)