diff mbox series

MAINTAINERS: Exclude m68k-only drivers from powerpc entry

Message ID 20230531125023.1121060-1-mpe@ellerman.id.au (mailing list archive)
State Accepted
Commit a43d52ab96f97967f4c5d28d1607fb1179057786
Headers show
Series MAINTAINERS: Exclude m68k-only drivers from powerpc entry | expand

Checks

Context Check Description
snowpatch_ozlabs/github-powerpc_sparse success Successfully ran 4 jobs.
snowpatch_ozlabs/github-powerpc_kernel_qemu success Successfully ran 24 jobs.
snowpatch_ozlabs/github-powerpc_clang success Successfully ran 6 jobs.

Commit Message

Michael Ellerman May 31, 2023, 12:50 p.m. UTC
The powerpc section has a "F:" entry for drivers/macintosh, matching all
files in or below drivers/macintosh. That is correct for the most part,
but there are a couple of m68k-only drivers in the directory, so exclude
those.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

Comments

Geert Uytterhoeven May 31, 2023, 12:59 p.m. UTC | #1
Hi Michael,

CC Finn

On Wed, May 31, 2023 at 2:50 PM Michael Ellerman <mpe@ellerman.id.au> wrote:
> The powerpc section has a "F:" entry for drivers/macintosh, matching all
> files in or below drivers/macintosh. That is correct for the most part,
> but there are a couple of m68k-only drivers in the directory, so exclude
> those.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Thanks for your patch!

> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11916,6 +11916,8 @@ L:      linuxppc-dev@lists.ozlabs.org
>  S:     Odd Fixes
>  F:     arch/powerpc/platforms/powermac/
>  F:     drivers/macintosh/
> +X:     drivers/macintosh/adb-iop.c
> +X:     drivers/macintosh/via-macii.c
>
>  LINUX FOR POWERPC (32-BIT AND 64-BIT)
>  M:     Michael Ellerman <mpe@ellerman.id.au>

LGTM, as there are already entries for these two files under
"M68K ON APPLE MACINTOSH".
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Which leads us to a related topic: Is Joshua still around?  Should Finn
be added or replace Joshua in the "M68K ON APPLE MACINTOSH" entry?

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Michael Schmitz May 31, 2023, 7:17 p.m. UTC | #2
Hi Geert,

On 1/06/23 00:59, Geert Uytterhoeven wrote:
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -11916,6 +11916,8 @@ L:      linuxppc-dev@lists.ozlabs.org
>>   S:     Odd Fixes
>>   F:     arch/powerpc/platforms/powermac/
>>   F:     drivers/macintosh/
>> +X:     drivers/macintosh/adb-iop.c
>> +X:     drivers/macintosh/via-macii.c
>>
>>   LINUX FOR POWERPC (32-BIT AND 64-BIT)
>>   M:     Michael Ellerman <mpe@ellerman.id.au>
> LGTM, as there are already entries for these two files under
> "M68K ON APPLE MACINTOSH".
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Which leads us to a related topic: Is Joshua still around?  Should Finn
> be added or replace Joshua in the "M68K ON APPLE MACINTOSH" entry?

Add Finn, at the very least (if he's agreed). Haven't seen mail from 
Joshua in the past 13 years myself.

Cheers,

     Michael

>
> Gr{oetje,eeting}s,
>
>                          Geert
>
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds
Finn Thain June 1, 2023, 12:22 a.m. UTC | #3
On Wed, 31 May 2023, Geert Uytterhoeven wrote:

> On Wed, May 31, 2023 at 2:50 PM Michael Ellerman <mpe@ellerman.id.au> wrote:
> > The powerpc section has a "F:" entry for drivers/macintosh, matching 
> > all files in or below drivers/macintosh. That is correct for the most 
> > part, but there are a couple of m68k-only drivers in the directory, so 
> > exclude those.
> >
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> 
> Thanks for your patch!
> 
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -11916,6 +11916,8 @@ L:      linuxppc-dev@lists.ozlabs.org
> >  S:     Odd Fixes
> >  F:     arch/powerpc/platforms/powermac/
> >  F:     drivers/macintosh/
> > +X:     drivers/macintosh/adb-iop.c
> > +X:     drivers/macintosh/via-macii.c
> >
> >  LINUX FOR POWERPC (32-BIT AND 64-BIT)
> >  M:     Michael Ellerman <mpe@ellerman.id.au>
> 
> LGTM, as there are already entries for these two files under
> "M68K ON APPLE MACINTOSH".

Right. I should have addded those "X files" in commit 2ae92e8b9b7.

> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> 
> Which leads us to a related topic: Is Joshua still around?  Should Finn 
> be added or replace Joshua in the "M68K ON APPLE MACINTOSH" entry?
> 

CC Joshua.

If he's not around perhaps we'll see some bounces.

Anyway, I'd be willing to either share the M68K ON APPLE MACINTOSH role or 
replace Joshua if he no longer wants that job.

But I hope he does still want it as there's always driver work to do.
Michael Ellerman June 1, 2023, 7:30 a.m. UTC | #4
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> Hi Michael,
>
> CC Finn
>
> On Wed, May 31, 2023 at 2:50 PM Michael Ellerman <mpe@ellerman.id.au> wrote:
>> The powerpc section has a "F:" entry for drivers/macintosh, matching all
>> files in or below drivers/macintosh. That is correct for the most part,
>> but there are a couple of m68k-only drivers in the directory, so exclude
>> those.
>>
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>
> Thanks for your patch!
>
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -11916,6 +11916,8 @@ L:      linuxppc-dev@lists.ozlabs.org
>>  S:     Odd Fixes
>>  F:     arch/powerpc/platforms/powermac/
>>  F:     drivers/macintosh/
>> +X:     drivers/macintosh/adb-iop.c
>> +X:     drivers/macintosh/via-macii.c
>>
>>  LINUX FOR POWERPC (32-BIT AND 64-BIT)
>>  M:     Michael Ellerman <mpe@ellerman.id.au>
>
> LGTM, as there are already entries for these two files under
> "M68K ON APPLE MACINTOSH".
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thanks.

cheers
Michael Ellerman June 1, 2023, 7:30 a.m. UTC | #5
Finn Thain <fthain@linux-m68k.org> writes:
> On Wed, 31 May 2023, Geert Uytterhoeven wrote:
>> On Wed, May 31, 2023 at 2:50 PM Michael Ellerman <mpe@ellerman.id.au> wrote:
>> > The powerpc section has a "F:" entry for drivers/macintosh, matching 
>> > all files in or below drivers/macintosh. That is correct for the most 
>> > part, but there are a couple of m68k-only drivers in the directory, so 
>> > exclude those.
>> >
>> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>> 
>> Thanks for your patch!
>> 
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -11916,6 +11916,8 @@ L:      linuxppc-dev@lists.ozlabs.org
>> >  S:     Odd Fixes
>> >  F:     arch/powerpc/platforms/powermac/
>> >  F:     drivers/macintosh/
>> > +X:     drivers/macintosh/adb-iop.c
>> > +X:     drivers/macintosh/via-macii.c
>> >
>> >  LINUX FOR POWERPC (32-BIT AND 64-BIT)
>> >  M:     Michael Ellerman <mpe@ellerman.id.au>
>> 
>> LGTM, as there are already entries for these two files under
>> "M68K ON APPLE MACINTOSH".
>
> Right. I should have addded those "X files" in commit 2ae92e8b9b7.

Or I should have suggested it when I acked that commit :}

cheers
Michael Ellerman July 3, 2023, 5:26 a.m. UTC | #6
On Wed, 31 May 2023 22:50:23 +1000, Michael Ellerman wrote:
> The powerpc section has a "F:" entry for drivers/macintosh, matching all
> files in or below drivers/macintosh. That is correct for the most part,
> but there are a couple of m68k-only drivers in the directory, so exclude
> those.
> 
> 

Applied to powerpc/next.

[1/1] MAINTAINERS: Exclude m68k-only drivers from powerpc entry
      https://git.kernel.org/powerpc/c/a43d52ab96f97967f4c5d28d1607fb1179057786

cheers
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 250518fc70ff..9bbb613d386a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11916,6 +11916,8 @@  L:	linuxppc-dev@lists.ozlabs.org
 S:	Odd Fixes
 F:	arch/powerpc/platforms/powermac/
 F:	drivers/macintosh/
+X:	drivers/macintosh/adb-iop.c
+X:	drivers/macintosh/via-macii.c
 
 LINUX FOR POWERPC (32-BIT AND 64-BIT)
 M:	Michael Ellerman <mpe@ellerman.id.au>