Message ID | 20230513100906.46672-3-shentey@gmail.com |
---|---|
State | New |
Headers | show |
Series | Trivial cleanups | expand |
On 13/05/2023 11:09, Bernhard Beschow wrote: > The function is unused since commit > bdad3654d3c55f478e538037d9eccd204e5fc8ee ('hw/arm/nseries: Remove > invalid/unnecessary n8x0_uart_setup()'). > > Signed-off-by: Bernhard Beschow <shentey@gmail.com> > --- > include/hw/arm/omap.h | 1 - > hw/char/omap_uart.c | 9 --------- > 2 files changed, 10 deletions(-) > > diff --git a/include/hw/arm/omap.h b/include/hw/arm/omap.h > index c275d9b681..067e9419f7 100644 > --- a/include/hw/arm/omap.h > +++ b/include/hw/arm/omap.h > @@ -724,7 +724,6 @@ struct omap_uart_s *omap2_uart_init(MemoryRegion *sysmem, > qemu_irq txdma, qemu_irq rxdma, > const char *label, Chardev *chr); > void omap_uart_reset(struct omap_uart_s *s); > -void omap_uart_attach(struct omap_uart_s *s, Chardev *chr); > > struct omap_mpuio_s; > qemu_irq *omap_mpuio_in_get(struct omap_mpuio_s *s); > diff --git a/hw/char/omap_uart.c b/hw/char/omap_uart.c > index 1c890b9201..6848bddb4e 100644 > --- a/hw/char/omap_uart.c > +++ b/hw/char/omap_uart.c > @@ -175,12 +175,3 @@ struct omap_uart_s *omap2_uart_init(MemoryRegion *sysmem, > > return s; > } > - > -void omap_uart_attach(struct omap_uart_s *s, Chardev *chr) > -{ > - /* TODO: Should reuse or destroy current s->serial */ > - s->serial = serial_mm_init(get_system_memory(), s->base, 2, s->irq, > - omap_clk_getrate(s->fclk) / 16, > - chr ?: qemu_chr_new("null", "null", NULL), > - DEVICE_NATIVE_ENDIAN); > -} A quick grep agrees, so: Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> ATB, Mark.
On 13/5/23 12:09, Bernhard Beschow wrote: > The function is unused since commit > bdad3654d3c55f478e538037d9eccd204e5fc8ee ('hw/arm/nseries: Remove > invalid/unnecessary n8x0_uart_setup()'). > > Signed-off-by: Bernhard Beschow <shentey@gmail.com> > --- > include/hw/arm/omap.h | 1 - > hw/char/omap_uart.c | 9 --------- > 2 files changed, 10 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/include/hw/arm/omap.h b/include/hw/arm/omap.h index c275d9b681..067e9419f7 100644 --- a/include/hw/arm/omap.h +++ b/include/hw/arm/omap.h @@ -724,7 +724,6 @@ struct omap_uart_s *omap2_uart_init(MemoryRegion *sysmem, qemu_irq txdma, qemu_irq rxdma, const char *label, Chardev *chr); void omap_uart_reset(struct omap_uart_s *s); -void omap_uart_attach(struct omap_uart_s *s, Chardev *chr); struct omap_mpuio_s; qemu_irq *omap_mpuio_in_get(struct omap_mpuio_s *s); diff --git a/hw/char/omap_uart.c b/hw/char/omap_uart.c index 1c890b9201..6848bddb4e 100644 --- a/hw/char/omap_uart.c +++ b/hw/char/omap_uart.c @@ -175,12 +175,3 @@ struct omap_uart_s *omap2_uart_init(MemoryRegion *sysmem, return s; } - -void omap_uart_attach(struct omap_uart_s *s, Chardev *chr) -{ - /* TODO: Should reuse or destroy current s->serial */ - s->serial = serial_mm_init(get_system_memory(), s->base, 2, s->irq, - omap_clk_getrate(s->fclk) / 16, - chr ?: qemu_chr_new("null", "null", NULL), - DEVICE_NATIVE_ENDIAN); -}
The function is unused since commit bdad3654d3c55f478e538037d9eccd204e5fc8ee ('hw/arm/nseries: Remove invalid/unnecessary n8x0_uart_setup()'). Signed-off-by: Bernhard Beschow <shentey@gmail.com> --- include/hw/arm/omap.h | 1 - hw/char/omap_uart.c | 9 --------- 2 files changed, 10 deletions(-)