| Message ID | 20230410011254.25675-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] soc/fsl/qe: fix usb.c build errors | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 6 jobs. |
Any comments on this patch? I am still seeing this build error. On 4/9/23 18:12, Randy Dunlap wrote: > Fix build errors in soc/fsl/qe/usb.c when QUICC_ENGINE is not set. > This happens when PPC_EP88XC is set, which selects CPM1 & CPM. > When CPM is set, USB_FSL_QE can be set without QUICC_ENGINE > being set. When USB_FSL_QE is set, QE_USB deafults to y, which > causes build errors when QUICC_ENGINE is not set. Making > QE_USB depend on QUICC_ENGINE prevents QE_USB from defaulting to y. > > Fixes these build errors: > > drivers/soc/fsl/qe/usb.o: in function `qe_usb_clock_set': > usb.c:(.text+0x1e): undefined reference to `qe_immr' > powerpc-linux-ld: usb.c:(.text+0x2a): undefined reference to `qe_immr' > powerpc-linux-ld: usb.c:(.text+0xbc): undefined reference to `qe_setbrg' > powerpc-linux-ld: usb.c:(.text+0xca): undefined reference to `cmxgcr_lock' > powerpc-linux-ld: usb.c:(.text+0xce): undefined reference to `cmxgcr_lock' > > Fixes: 5e41486c408e ("powerpc/QE: add support for QE USB clocks routing") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Link: https://lore.kernel.org/all/202301101500.pillNv6R-lkp@intel.com/ > Suggested-by: Michael Ellerman <mpe@ellerman.id.au> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu> > Cc: Leo Li <leoyang.li@nxp.com> > Cc: Masahiro Yamada <masahiroy@kernel.org> > Cc: Nicolas Schier <nicolas@fjasle.eu> > Cc: Qiang Zhao <qiang.zhao@nxp.com> > Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: Kumar Gala <galak@kernel.crashing.org> > --- > v2: drop Anton Vorontsov <avorontsov@ru.mvista.com>; rebase/resend > > drivers/soc/fsl/qe/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig > --- a/drivers/soc/fsl/qe/Kconfig > +++ b/drivers/soc/fsl/qe/Kconfig > @@ -62,6 +62,7 @@ config QE_TDM > > config QE_USB > bool > + depends on QUICC_ENGINE > default y if USB_FSL_QE > help > QE USB Controller support
diff -- a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig --- a/drivers/soc/fsl/qe/Kconfig +++ b/drivers/soc/fsl/qe/Kconfig @@ -62,6 +62,7 @@ config QE_TDM config QE_USB bool + depends on QUICC_ENGINE default y if USB_FSL_QE help QE USB Controller support
Fix build errors in soc/fsl/qe/usb.c when QUICC_ENGINE is not set. This happens when PPC_EP88XC is set, which selects CPM1 & CPM. When CPM is set, USB_FSL_QE can be set without QUICC_ENGINE being set. When USB_FSL_QE is set, QE_USB deafults to y, which causes build errors when QUICC_ENGINE is not set. Making QE_USB depend on QUICC_ENGINE prevents QE_USB from defaulting to y. Fixes these build errors: drivers/soc/fsl/qe/usb.o: in function `qe_usb_clock_set': usb.c:(.text+0x1e): undefined reference to `qe_immr' powerpc-linux-ld: usb.c:(.text+0x2a): undefined reference to `qe_immr' powerpc-linux-ld: usb.c:(.text+0xbc): undefined reference to `qe_setbrg' powerpc-linux-ld: usb.c:(.text+0xca): undefined reference to `cmxgcr_lock' powerpc-linux-ld: usb.c:(.text+0xce): undefined reference to `cmxgcr_lock' Fixes: 5e41486c408e ("powerpc/QE: add support for QE USB clocks routing") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/all/202301101500.pillNv6R-lkp@intel.com/ Suggested-by: Michael Ellerman <mpe@ellerman.id.au> Cc: Christophe Leroy <christophe.leroy@csgroup.eu> Cc: Leo Li <leoyang.li@nxp.com> Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Nicolas Schier <nicolas@fjasle.eu> Cc: Qiang Zhao <qiang.zhao@nxp.com> Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org> Cc: linux-arm-kernel@lists.infradead.org Cc: Kumar Gala <galak@kernel.crashing.org> --- v2: drop Anton Vorontsov <avorontsov@ru.mvista.com>; rebase/resend drivers/soc/fsl/qe/Kconfig | 1 + 1 file changed, 1 insertion(+)