Message ID | 20230404011956.90375-1-dinahbaum123@gmail.com |
---|---|
Headers | show |
Series | Enable -cpu <cpu>,help | expand |
Markus, I think you said you would review this patchset? thanks -- PMM On Tue, 4 Apr 2023 at 02:22, Dinah Baum <dinahbaum123@gmail.com> wrote: > > Part 1 is a refactor/code motion patch for > qapi/machine target required for setup of > > Part 2 which enables query-cpu-model-expansion > on all architectures > > Part 3 implements the '<cpu>,help' feature > > Limitations: > Currently only 'FULL' expansion queries are implemented since > that's the only type enabled on the architectures that > allow feature probing > > Unlike the 'device,help' command, default values aren't > printed > > Changes since v2: Rebase > > Dinah Baum (3): > qapi/machine-target: refactor machine-target > cpu, qapi, target/arm, i386, s390x: Generalize > query-cpu-model-expansion > cpu, qdict, vl: Enable printing options for CPU type > > MAINTAINERS | 1 + > cpu.c | 61 +++++++++++++++ > include/exec/cpu-common.h | 10 +++ > include/qapi/qmp/qdict.h | 2 + > qapi/machine-target-common.json | 130 +++++++++++++++++++++++++++++++ > qapi/machine-target.json | 129 +----------------------------- > qapi/meson.build | 1 + > qemu-options.hx | 7 +- > qobject/qdict.c | 5 ++ > softmmu/vl.c | 36 ++++++++- > target/arm/arm-qmp-cmds.c | 7 +- > target/arm/cpu.h | 7 +- > target/i386/cpu-sysemu.c | 7 +- > target/i386/cpu.h | 6 ++ > target/s390x/cpu.h | 7 ++ > target/s390x/cpu_models_sysemu.c | 6 +- > 16 files changed, 278 insertions(+), 144 deletions(-) > create mode 100644 qapi/machine-target-common.json > > -- > 2.30.2
Peter Maydell <peter.maydell@linaro.org> writes:
> Markus, I think you said you would review this patchset?
I did, but it got crowded out. I'm going to look at it now. Wish me
absence of interruptions...
On Mon, 3 Apr 2023 21:19:53 -0400 Dinah Baum <dinahbaum123@gmail.com> wrote: > Part 1 is a refactor/code motion patch for > qapi/machine target required for setup of > > Part 2 which enables query-cpu-model-expansion > on all architectures > > Part 3 implements the '<cpu>,help' feature > > Limitations: > Currently only 'FULL' expansion queries are implemented since > that's the only type enabled on the architectures that > allow feature probing > > Unlike the 'device,help' command, default values aren't > printed what's wrong with 'device,help' if it's used for cpu devices? > > Changes since v2: Rebase > > Dinah Baum (3): > qapi/machine-target: refactor machine-target > cpu, qapi, target/arm, i386, s390x: Generalize > query-cpu-model-expansion > cpu, qdict, vl: Enable printing options for CPU type > > MAINTAINERS | 1 + > cpu.c | 61 +++++++++++++++ > include/exec/cpu-common.h | 10 +++ > include/qapi/qmp/qdict.h | 2 + > qapi/machine-target-common.json | 130 +++++++++++++++++++++++++++++++ > qapi/machine-target.json | 129 +----------------------------- > qapi/meson.build | 1 + > qemu-options.hx | 7 +- > qobject/qdict.c | 5 ++ > softmmu/vl.c | 36 ++++++++- > target/arm/arm-qmp-cmds.c | 7 +- > target/arm/cpu.h | 7 +- > target/i386/cpu-sysemu.c | 7 +- > target/i386/cpu.h | 6 ++ > target/s390x/cpu.h | 7 ++ > target/s390x/cpu_models_sysemu.c | 6 +- > 16 files changed, 278 insertions(+), 144 deletions(-) > create mode 100644 qapi/machine-target-common.json >
On Fri, 26 May 2023 at 15:28, Igor Mammedov <imammedo@redhat.com> wrote: > > On Mon, 3 Apr 2023 21:19:53 -0400 > Dinah Baum <dinahbaum123@gmail.com> wrote: > > > Part 1 is a refactor/code motion patch for > > qapi/machine target required for setup of > > > > Part 2 which enables query-cpu-model-expansion > > on all architectures > > > > Part 3 implements the '<cpu>,help' feature > > > > Limitations: > > Currently only 'FULL' expansion queries are implemented since > > that's the only type enabled on the architectures that > > allow feature probing > > > > Unlike the 'device,help' command, default values aren't > > printed > > what's wrong with 'device,help' if it's used for cpu devices? Nothing, but almost no creation/configuration of CPUs is done with -device. -cpu is by far the more usual way, so '-cpu foo,help' should work... -- PMM