| Message ID | cover.1678351495.git.viresh.kumar@linaro.org |
|---|---|
| Headers | show |
| Series | qemu: vhost-user: Support Xen memory mapping quirks | expand |
On 09-03-23, 14:20, Viresh Kumar wrote: > Hello, > > This patchset tries to update the vhost-user protocol to make it support special > memory mapping required in case of Xen hypervisor. > > The first patch is mostly cleanup and second one introduces a new xen specific > feature. > > V2->V3: > - Remove the extra message and instead update the memory regions to carry > additional data. > > - Drop the one region one mmap relationship and allow back-end to map only parts > of a region at once, required for Xen grant mappings. > > - Additional cleanup patch 1/2. Stefan, Does this version look better ?
On Thu, Mar 09, 2023 at 02:20:59PM +0530, Viresh Kumar wrote: > Hello, > > This patchset tries to update the vhost-user protocol to make it support special > memory mapping required in case of Xen hypervisor. > > The first patch is mostly cleanup and second one introduces a new xen specific > feature. > > V2->V3: > - Remove the extra message and instead update the memory regions to carry > additional data. > > - Drop the one region one mmap relationship and allow back-end to map only parts > of a region at once, required for Xen grant mappings. > > - Additional cleanup patch 1/2. > > V1->V2: > - Make the custom mmap feature Xen specific, instead of being generic. > - Clearly define which memory regions are impacted by this change. > - Allow VHOST_USER_SET_XEN_MMAP to be called multiple times. > - Additional Bit(2) property in flags. Looks good, thanks! Michael is the maintainer and this patch series will go through his tree. Stefan
On 09-03-23, 14:20, Viresh Kumar wrote: > Hello, > > This patchset tries to update the vhost-user protocol to make it support special > memory mapping required in case of Xen hypervisor. > > The first patch is mostly cleanup and second one introduces a new xen specific > feature. Can we apply this now ? I have developed code for rust-vmm crates based on this and we need to get this merged/finalized first before merging those changes. Thanks.
Viresh Kumar <viresh.kumar@linaro.org> writes: > On 09-03-23, 14:20, Viresh Kumar wrote: >> Hello, >> >> This patchset tries to update the vhost-user protocol to make it support special >> memory mapping required in case of Xen hypervisor. >> >> The first patch is mostly cleanup and second one introduces a new xen specific >> feature. > > Can we apply this now ? I have developed code for rust-vmm crates > based on this and we need to get this merged/finalized first before > merging those changes. I've queued into my virtio/vhost-user-device series so I'll get merged with that series unless mst wants to take it now. > > Thanks.
On Wed, Apr 05, 2023 at 11:00:34AM +0100, Alex Bennée wrote: > > Viresh Kumar <viresh.kumar@linaro.org> writes: > > > On 09-03-23, 14:20, Viresh Kumar wrote: > >> Hello, > >> > >> This patchset tries to update the vhost-user protocol to make it support special > >> memory mapping required in case of Xen hypervisor. > >> > >> The first patch is mostly cleanup and second one introduces a new xen specific > >> feature. > > > > Can we apply this now ? I have developed code for rust-vmm crates > > based on this and we need to get this merged/finalized first before > > merging those changes. > > > I've queued into my virtio/vhost-user-device series so I'll get merged > with that series unless mst wants to take it now. Well the patches are tagged and I was going to take these after the release. Probably easier not to work on this in two trees. Still if there's something in your tree being blocked by these patches then Acked-by: Michael S. Tsirkin <mst@redhat.com> Let me know. > > > > Thanks. > > > -- > Alex Bennée > Virtualisation Tech Lead @ Linaro
"Michael S. Tsirkin" <mst@redhat.com> writes: > On Wed, Apr 05, 2023 at 11:00:34AM +0100, Alex Bennée wrote: >> >> Viresh Kumar <viresh.kumar@linaro.org> writes: >> >> > On 09-03-23, 14:20, Viresh Kumar wrote: >> >> Hello, >> >> >> >> This patchset tries to update the vhost-user protocol to make it support special >> >> memory mapping required in case of Xen hypervisor. >> >> >> >> The first patch is mostly cleanup and second one introduces a new xen specific >> >> feature. >> > >> > Can we apply this now ? I have developed code for rust-vmm crates >> > based on this and we need to get this merged/finalized first before >> > merging those changes. >> >> >> I've queued into my virtio/vhost-user-device series so I'll get merged >> with that series unless mst wants to take it now. > > Well the patches are tagged and I was going to take these after the release. > Probably easier not to work on this in two trees. > Still if there's something in your tree being blocked > by these patches then > Acked-by: Michael S. Tsirkin <mst@redhat.com> > Let me know. The virtio/vhost-user-device tree work is orthogonal to this vhost-user enhancement although all the work is related to our latest VirtIO project inside Linaro, Orko: https://linaro.atlassian.net/wiki/spaces/ORKO/overview So if you are happy please take these patches now for when the tree re-opens. > > >> > >> > Thanks. >> >> >> -- >> Alex Bennée >> Virtualisation Tech Lead @ Linaro
On Wed, Apr 05, 2023 at 11:24:43AM +0100, Alex Bennée wrote: > > "Michael S. Tsirkin" <mst@redhat.com> writes: > > > On Wed, Apr 05, 2023 at 11:00:34AM +0100, Alex Bennée wrote: > >> > >> Viresh Kumar <viresh.kumar@linaro.org> writes: > >> > >> > On 09-03-23, 14:20, Viresh Kumar wrote: > >> >> Hello, > >> >> > >> >> This patchset tries to update the vhost-user protocol to make it support special > >> >> memory mapping required in case of Xen hypervisor. > >> >> > >> >> The first patch is mostly cleanup and second one introduces a new xen specific > >> >> feature. > >> > > >> > Can we apply this now ? I have developed code for rust-vmm crates > >> > based on this and we need to get this merged/finalized first before > >> > merging those changes. > >> > >> > >> I've queued into my virtio/vhost-user-device series so I'll get merged > >> with that series unless mst wants to take it now. > > > > Well the patches are tagged and I was going to take these after the release. > > Probably easier not to work on this in two trees. > > Still if there's something in your tree being blocked > > by these patches then > > Acked-by: Michael S. Tsirkin <mst@redhat.com> > > Let me know. > > The virtio/vhost-user-device tree work is orthogonal to this vhost-user > enhancement although all the work is related to our latest VirtIO > project inside Linaro, Orko: > https://linaro.atlassian.net/wiki/spaces/ORKO/overview > > So if you are happy please take these patches now for when the tree > re-opens. Yes, I tagged them for when the tree reopens. > > > > > >> > > >> > Thanks. > >> > >> > >> -- > >> Alex Bennée > >> Virtualisation Tech Lead @ Linaro > > > -- > Alex Bennée > Virtualisation Tech Lead @ Linaro