| Message ID | 20230225094903.53167-1-philmd@linaro.org |
|---|---|
| Headers | show |
| Series | dump: Make most of it target agnostic (build once) | expand |
On Sat, Feb 25, 2023 at 1:49 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote: > All series reviewed. > > Since v5: > - reword one commit description (Thomas) > - drop CONFIG_SOFTMMU, unify softmmu_ss (Richard) > > Since v4: > - more unused headers removed > - KISS, use a bit of #ifdef'ry to avoid a stub file > > Thanks to Richard help, we can now build dump.o once > for all targets, keeping win_dump.o for x86* targets. > > Philippe Mathieu-Daudé (5): > dump: Replace tswapN() -> cpu_to_dumpN() > dump: Replace TARGET_PAGE_SIZE -> qemu_target_page_size() > dump: Clean included headers > dump: Simplify compiling win_dump.o by introducing > win_dump_available() > dump: Add create_win_dump() stub for non-x86 targets > > dump/dump-hmp-cmds.c | 2 +- > dump/dump.c | 35 +++++++++++++---------------------- > dump/meson.build | 6 ++---- > dump/win_dump.c | 38 ++++++++++++++++++++++++++++---------- > dump/win_dump.h | 5 ++++- > 5 files changed, 48 insertions(+), 38 deletions(-) > > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
On 26/2/23 13:39, Marc-André Lureau wrote: > Philippe Mathieu-Daudé (5): > dump: Replace tswapN() -> cpu_to_dumpN() > dump: Replace TARGET_PAGE_SIZE -> qemu_target_page_size() > dump: Clean included headers > dump: Simplify compiling win_dump.o by introducing > win_dump_available() > dump: Add create_win_dump() stub for non-x86 targets > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com > <mailto:marcandre.lureau@redhat.com>> > Thanks, I'm going to queue this series with various qdev cleanups.
All series reviewed. Since v5: - reword one commit description (Thomas) - drop CONFIG_SOFTMMU, unify softmmu_ss (Richard) Since v4: - more unused headers removed - KISS, use a bit of #ifdef'ry to avoid a stub file Thanks to Richard help, we can now build dump.o once for all targets, keeping win_dump.o for x86* targets. Philippe Mathieu-Daudé (5): dump: Replace tswapN() -> cpu_to_dumpN() dump: Replace TARGET_PAGE_SIZE -> qemu_target_page_size() dump: Clean included headers dump: Simplify compiling win_dump.o by introducing win_dump_available() dump: Add create_win_dump() stub for non-x86 targets dump/dump-hmp-cmds.c | 2 +- dump/dump.c | 35 +++++++++++++---------------------- dump/meson.build | 6 ++---- dump/win_dump.c | 38 ++++++++++++++++++++++++++++---------- dump/win_dump.h | 5 ++++- 5 files changed, 48 insertions(+), 38 deletions(-)