Message ID | 20221126051002.123199-1-linux@weissschuh.net (mailing list archive) |
---|---|
State | Handled Elsewhere, archived |
Headers | show |
Series | [1/3] firmware_loader: remove #include <generated/utsrelease.h> | expand |
On Sat, Nov 26, 2022 at 2:10 PM Thomas Weißschuh <linux@weissschuh.net> wrote: > > utsrelease.h is potentially generated on each build. > By removing this unused include we can get rid of some spurious > recompilations. > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > --- Reviewed-by: Masahiro Yamada <masahiroy@kernel.org> > drivers/base/firmware_loader/firmware.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h > index fe77e91c38a2..bf549d6500d7 100644 > --- a/drivers/base/firmware_loader/firmware.h > +++ b/drivers/base/firmware_loader/firmware.h > @@ -9,8 +9,6 @@ > #include <linux/list.h> > #include <linux/completion.h> > > -#include <generated/utsrelease.h> > - > /** > * enum fw_opt - options to control firmware loading behaviour > * > > base-commit: 0b1dcc2cf55ae6523c6fbd0d741b3ac28c9f4536 > -- > 2.38.1 >
On 11/25/22 21:09, Thomas Weißschuh wrote: > utsrelease.h is potentially generated on each build. > By removing this unused include we can get rid of some spurious > recompilations. Reviewed-by: Russ Weight <russell.h.weight@intel.com> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > --- > drivers/base/firmware_loader/firmware.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h > index fe77e91c38a2..bf549d6500d7 100644 > --- a/drivers/base/firmware_loader/firmware.h > +++ b/drivers/base/firmware_loader/firmware.h > @@ -9,8 +9,6 @@ > #include <linux/list.h> > #include <linux/completion.h> > > -#include <generated/utsrelease.h> > - > /** > * enum fw_opt - options to control firmware loading behaviour > * > > base-commit: 0b1dcc2cf55ae6523c6fbd0d741b3ac28c9f4536
On Tue, Nov 29, 2022 at 10:18 AM Russ Weight <russell.h.weight@intel.com> wrote: > > > > On 11/25/22 21:09, Thomas Weißschuh wrote: > > utsrelease.h is potentially generated on each build. > > By removing this unused include we can get rid of some spurious > > recompilations. > Reviewed-by: Russ Weight <russell.h.weight@intel.com> > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > > --- > > drivers/base/firmware_loader/firmware.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h > > index fe77e91c38a2..bf549d6500d7 100644 > > --- a/drivers/base/firmware_loader/firmware.h > > +++ b/drivers/base/firmware_loader/firmware.h > > @@ -9,8 +9,6 @@ > > #include <linux/list.h> > > #include <linux/completion.h> > > > > -#include <generated/utsrelease.h> > > - > > /** > > * enum fw_opt - options to control firmware loading behaviour > > * > > > > base-commit: 0b1dcc2cf55ae6523c6fbd0d741b3ac28c9f4536 > Applied to linux-kbuild. Thanks.
On Sat, 26 Nov 2022 06:09:59 +0100, Thomas Weißschuh wrote: > utsrelease.h is potentially generated on each build. > By removing this unused include we can get rid of some spurious > recompilations. > > Applied to powerpc/next. [2/3] powerpc/book3e: remove #include <generated/utsrelease.h> https://git.kernel.org/powerpc/c/d5090716be6791ada9ee142163a4934c1c147aaa cheers
diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h index fe77e91c38a2..bf549d6500d7 100644 --- a/drivers/base/firmware_loader/firmware.h +++ b/drivers/base/firmware_loader/firmware.h @@ -9,8 +9,6 @@ #include <linux/list.h> #include <linux/completion.h> -#include <generated/utsrelease.h> - /** * enum fw_opt - options to control firmware loading behaviour *
utsrelease.h is potentially generated on each build. By removing this unused include we can get rid of some spurious recompilations. Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> --- drivers/base/firmware_loader/firmware.h | 2 -- 1 file changed, 2 deletions(-) base-commit: 0b1dcc2cf55ae6523c6fbd0d741b3ac28c9f4536