diff mbox series

[1/6] powerpc/pseries: fix the object owners enum value in plpks driver

Message ID 20221106205839.600442-2-nayna@linux.ibm.com (mailing list archive)
State Accepted
Commit 2330757e0be0acad88852e211dcd6106390a729b
Headers show
Series powerpc/pseries - bugfixes/cleanups for PLPKS driver | expand

Commit Message

Nayna Jain Nov. 6, 2022, 8:58 p.m. UTC
OS_VAR_LINUX enum in PLPKS driver should be 0x02 instead of 0x01.

Fixes: 2454a7af0f2a ("powerpc/pseries: define driver for Platform KeyStore")
Signed-off-by: Nayna Jain <nayna@linux.ibm.com>
---
 arch/powerpc/platforms/pseries/plpks.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Donnellan Nov. 25, 2022, 3:54 a.m. UTC | #1
On Sun, 2022-11-06 at 15:58 -0500, Nayna Jain wrote:
> OS_VAR_LINUX enum in PLPKS driver should be 0x02 instead of 0x01.

This should be PLPKS_VAR_LINUX. And it's a macro, not an enum.

The new value does indeed match the (currently IBM internal)
specification - 0x01 is AIX.

> 
> Fixes: 2454a7af0f2a ("powerpc/pseries: define driver for Platform
> KeyStore")
> Signed-off-by: Nayna Jain <nayna@linux.ibm.com>

Should be noted that at present, this macro isn't used anywhere - it is
used in a future series.

> ---
>  arch/powerpc/platforms/pseries/plpks.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/pseries/plpks.h
> b/arch/powerpc/platforms/pseries/plpks.h
> index c6a291367bb1..275ccd86bfb5 100644
> --- a/arch/powerpc/platforms/pseries/plpks.h
> +++ b/arch/powerpc/platforms/pseries/plpks.h
> @@ -17,7 +17,7 @@
>  #define WORLDREADABLE 0x08000000
>  #define SIGNEDUPDATE 0x01000000
>  
> -#define PLPKS_VAR_LINUX        0x01
> +#define PLPKS_VAR_LINUX        0x02
>  #define PLPKS_VAR_COMMON       0x04
>  
>  struct plpks_var {
diff mbox series

Patch

diff --git a/arch/powerpc/platforms/pseries/plpks.h b/arch/powerpc/platforms/pseries/plpks.h
index c6a291367bb1..275ccd86bfb5 100644
--- a/arch/powerpc/platforms/pseries/plpks.h
+++ b/arch/powerpc/platforms/pseries/plpks.h
@@ -17,7 +17,7 @@ 
 #define WORLDREADABLE 0x08000000
 #define SIGNEDUPDATE 0x01000000
 
-#define PLPKS_VAR_LINUX	0x01
+#define PLPKS_VAR_LINUX	0x02
 #define PLPKS_VAR_COMMON	0x04
 
 struct plpks_var {