| Message ID | 20221108142347.1322674-1-afaria@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qapi/block-core: Fix BlockdevOptionsNvmeIoUring @path description | expand |
On Tue, Nov 08, 2022 at 02:23:47PM +0000, Alberto Faria wrote: >The nvme-io_uring BlockDriver's path option must point at the character >device of an NVMe namespace, not at an image file. > >Fixes: fd66dbd424f5 ("blkio: add libblkio block driver") >Suggested-by: Stefano Garzarella <sgarzare@redhat.com> >Signed-off-by: Alberto Faria <afaria@redhat.com> >--- > qapi/block-core.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for fixing this: Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > >diff --git a/qapi/block-core.json b/qapi/block-core.json >index 6d904004f8..95ac4fa634 100644 >--- a/qapi/block-core.json >+++ b/qapi/block-core.json >@@ -3704,7 +3704,7 @@ > # > # Driver specific block device options for the nvme-io_uring backend. > # >-# @path: path to the image file >+# @path: path to the NVMe namespace's character device (e.g. /dev/ng0n1). > # > # Since: 7.2 > ## >-- >2.38.1 >
Am 08.11.2022 um 15:23 hat Alberto Faria geschrieben: > The nvme-io_uring BlockDriver's path option must point at the character > device of an NVMe namespace, not at an image file. > > Fixes: fd66dbd424f5 ("blkio: add libblkio block driver") > Suggested-by: Stefano Garzarella <sgarzare@redhat.com> > Signed-off-by: Alberto Faria <afaria@redhat.com> Thanks, applied to the block branch. Kevin
diff --git a/qapi/block-core.json b/qapi/block-core.json index 6d904004f8..95ac4fa634 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -3704,7 +3704,7 @@ # # Driver specific block device options for the nvme-io_uring backend. # -# @path: path to the image file +# @path: path to the NVMe namespace's character device (e.g. /dev/ng0n1). # # Since: 7.2 ##
The nvme-io_uring BlockDriver's path option must point at the character device of an NVMe namespace, not at an image file. Fixes: fd66dbd424f5 ("blkio: add libblkio block driver") Suggested-by: Stefano Garzarella <sgarzare@redhat.com> Signed-off-by: Alberto Faria <afaria@redhat.com> --- qapi/block-core.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)