Message ID | c31207c.c3.1844d85a6aa.Coremail.wangkailong@jari.cn (mailing list archive) |
---|---|
State | Rejected, archived |
Headers | show |
Series | macintosh: Fix warning comparing pointer to 0 | expand |
Context | Check | Description |
---|---|---|
snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 6 jobs. |
snowpatch_ozlabs/github-powerpc_kernel_qemu | fail | boot (ppc64le_guest_defconfig, pseries+p8+tcg, pseries+p9+tcg, qemu-system-ppc64, ppc64le-rootfs.... failed at step Run qemu-pseries+p8+tcg with fedora-34 build kernel. |
Le 06/11/2022 à 16:18, wangkailong@jari.cn a écrit : > Fix the following coccicheck warning: > > drivers/macintosh/macio-adb.c:103:13-14: WARNING comparing pointer to 0. > > Signed-off-by: KaiLong Wang <wangkailong@jari.cn> > --- > drivers/macintosh/macio-adb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/macintosh/macio-adb.c b/drivers/macintosh/macio-adb.c > index 9b63bd2551c6..1c1c375a817d 100644 > --- a/drivers/macintosh/macio-adb.c > +++ b/drivers/macintosh/macio-adb.c > @@ -100,7 +100,7 @@ int macio_init(void) > unsigned int irq; > > adbs = of_find_compatible_node(NULL, "adb", "chrp,adb0"); > - if (adbs == 0) > + if (adbs) Hi no, this should be "if (!adbs)" CJ > return -ENXIO; > > if (of_address_to_resource(adbs, 0, &r)) {
Le 06/11/2022 à 17:08, Christophe JAILLET a écrit : > Le 06/11/2022 à 16:18, wangkailong@jari.cn a écrit : >> Fix the following coccicheck warning: >> >> drivers/macintosh/macio-adb.c:103:13-14: WARNING comparing pointer to 0. >> >> Signed-off-by: KaiLong Wang <wangkailong@jari.cn> We already have such patches awaiting for application, see https://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=83647 Please check patchwork before submitting such fixes as they may already exist. Thanks Christophe >> --- >> drivers/macintosh/macio-adb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/macintosh/macio-adb.c >> b/drivers/macintosh/macio-adb.c >> index 9b63bd2551c6..1c1c375a817d 100644 >> --- a/drivers/macintosh/macio-adb.c >> +++ b/drivers/macintosh/macio-adb.c >> @@ -100,7 +100,7 @@ int macio_init(void) >> unsigned int irq; >> adbs = of_find_compatible_node(NULL, "adb", "chrp,adb0"); >> - if (adbs == 0) >> + if (adbs) > > Hi > no, this should be "if (!adbs)" > > CJ > >> return -ENXIO; >> if (of_address_to_resource(adbs, 0, &r)) { >
diff --git a/drivers/macintosh/macio-adb.c b/drivers/macintosh/macio-adb.c index 9b63bd2551c6..1c1c375a817d 100644 --- a/drivers/macintosh/macio-adb.c +++ b/drivers/macintosh/macio-adb.c @@ -100,7 +100,7 @@ int macio_init(void) unsigned int irq; adbs = of_find_compatible_node(NULL, "adb", "chrp,adb0"); - if (adbs == 0) + if (adbs) return -ENXIO; if (of_address_to_resource(adbs, 0, &r)) {
Fix the following coccicheck warning: drivers/macintosh/macio-adb.c:103:13-14: WARNING comparing pointer to 0. Signed-off-by: KaiLong Wang <wangkailong@jari.cn> --- drivers/macintosh/macio-adb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)