| Message ID | 20220927150419.1503001-1-mpe@ellerman.id.au (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] powerpc: Make stack frame marker upper case | expand |
On Wed, 28 Sep 2022 01:04:18 +1000, Michael Ellerman wrote: > Now that the stack frame regs marker is only 32-bits it is not as > obvious in memory dumps and easier to miss, eg: > > c000000004733e40 0000000000000000 0000000000000000 |................| > c000000004733e50 0000000000000000 0000000000000000 |................| > c000000004733e60 0000000000000000 0000000000000000 |................| > c000000004733e70 7367657200000000 0000000000000000 |sger............| > c000000004733e80 a700000000000000 708897f7ff7f0000 |........p.......| > c000000004733e90 0073428fff7f0000 208997f7ff7f0000 |.sB..... .......| > c000000004733ea0 0100000000000000 ffffffffffffffff |................| > c000000004733eb0 0000000000000000 0000000000000000 |................| > > [...] Applied to powerpc/next. [1/2] powerpc: Make stack frame marker upper case https://git.kernel.org/powerpc/c/bbd71709087a9d486d1da42399eec14e106072f2 [2/2] powerpc: Reverse stack frame marker on little endian https://git.kernel.org/powerpc/c/19c95df1277c48e3ef8cc7d9f1d315dce949f203 cheers
diff --git a/arch/powerpc/include/asm/ptrace.h b/arch/powerpc/include/asm/ptrace.h index 5b496e589d54..6c23d1d25dc7 100644 --- a/arch/powerpc/include/asm/ptrace.h +++ b/arch/powerpc/include/asm/ptrace.h @@ -99,7 +99,7 @@ struct pt_regs #define STACK_FRAME_WITH_PT_REGS (STACK_FRAME_OVERHEAD + sizeof(struct pt_regs)) -#define STACK_FRAME_REGS_MARKER ASM_CONST(0x72656773) +#define STACK_FRAME_REGS_MARKER ASM_CONST(0x52454753) #ifdef __powerpc64__
Now that the stack frame regs marker is only 32-bits it is not as obvious in memory dumps and easier to miss, eg: c000000004733e40 0000000000000000 0000000000000000 |................| c000000004733e50 0000000000000000 0000000000000000 |................| c000000004733e60 0000000000000000 0000000000000000 |................| c000000004733e70 7367657200000000 0000000000000000 |sger............| c000000004733e80 a700000000000000 708897f7ff7f0000 |........p.......| c000000004733e90 0073428fff7f0000 208997f7ff7f0000 |.sB..... .......| c000000004733ea0 0100000000000000 ffffffffffffffff |................| c000000004733eb0 0000000000000000 0000000000000000 |................| So make it upper case to make it stand out a bit more: c000000004733e70 5347455200000000 0000000000000000 |SGER............| Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> --- arch/powerpc/include/asm/ptrace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)