Message ID | 20220906072006.337099-1-ye.xingchen@zte.com.cn (mailing list archive) |
---|---|
State | Accepted |
Headers | show |
Series | [linux-next] ocxl: Remove the unneeded result variable | expand |
Context | Check | Description |
---|---|---|
snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 10 jobs. |
snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 10 jobs. |
snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 6 jobs. |
snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 23 jobs. |
On Tue, 2022-09-06 at 07:20 +0000, cgel.zte@gmail.com wrote: > From: ye xingchen <ye.xingchen@zte.com.cn> > > Return the value opal_npu_spa_clear_cache() directly instead of > storing > it in another redundant variable. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> Acked-by: Andrew Donnellan <ajd@linux.ibm.com> > --- > arch/powerpc/platforms/powernv/ocxl.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/ocxl.c > b/arch/powerpc/platforms/powernv/ocxl.c > index 27c936075031..629067781cec 100644 > --- a/arch/powerpc/platforms/powernv/ocxl.c > +++ b/arch/powerpc/platforms/powernv/ocxl.c > @@ -478,10 +478,8 @@ EXPORT_SYMBOL_GPL(pnv_ocxl_spa_release); > int pnv_ocxl_spa_remove_pe_from_cache(void *platform_data, int > pe_handle) > { > struct spa_data *data = (struct spa_data *) platform_data; > - int rc; > > - rc = opal_npu_spa_clear_cache(data->phb_opal_id, data->bdfn, > pe_handle); > - return rc; > + return opal_npu_spa_clear_cache(data->phb_opal_id, data- > >bdfn, pe_handle); > } > EXPORT_SYMBOL_GPL(pnv_ocxl_spa_remove_pe_from_cache); >
On Tue, 6 Sep 2022 07:20:06 +0000, cgel.zte@gmail.com wrote: > From: ye xingchen <ye.xingchen@zte.com.cn> > > Return the value opal_npu_spa_clear_cache() directly instead of storing > it in another redundant variable. > > Applied to powerpc/next. [1/1] ocxl: Remove the unneeded result variable https://git.kernel.org/powerpc/c/5e4952656bca1b5d8c2be36682dc66d844797ad2 cheers
diff --git a/arch/powerpc/platforms/powernv/ocxl.c b/arch/powerpc/platforms/powernv/ocxl.c index 27c936075031..629067781cec 100644 --- a/arch/powerpc/platforms/powernv/ocxl.c +++ b/arch/powerpc/platforms/powernv/ocxl.c @@ -478,10 +478,8 @@ EXPORT_SYMBOL_GPL(pnv_ocxl_spa_release); int pnv_ocxl_spa_remove_pe_from_cache(void *platform_data, int pe_handle) { struct spa_data *data = (struct spa_data *) platform_data; - int rc; - rc = opal_npu_spa_clear_cache(data->phb_opal_id, data->bdfn, pe_handle); - return rc; + return opal_npu_spa_clear_cache(data->phb_opal_id, data->bdfn, pe_handle); } EXPORT_SYMBOL_GPL(pnv_ocxl_spa_remove_pe_from_cache);