diff mbox series

[linux-next] macintosh/windfarm: fix comparing pointer to 0

Message ID 20220918155043.210309-1-xu.panda@zte.com.cn (mailing list archive)
State Changes Requested
Headers show
Series [linux-next] macintosh/windfarm: fix comparing pointer to 0 | expand

Commit Message

CGEL Sept. 18, 2022, 3:50 p.m. UTC 
From: Xu Panda <xu.panda@zte.com.cn>

Comparing pointer whith NULL instead of comparing pointer to 0.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
---
 drivers/macintosh/windfarm_pm121.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Arnd Bergmann Sept. 18, 2022, 5:45 p.m. UTC | #1 
On Sun, Sep 18, 2022, at 5:50 PM, cgel.zte@gmail.com wrote:
> @@ -970,7 +970,7 @@ static int pm121_init_pm(void)
>         const struct smu_sdbp_header *hdr;
>
>         hdr = smu_get_sdb_partition(SMU_SDB_SENSORTREE_ID, NULL);
> -       if (hdr != 0) {
> +       if (hdr != NULL) {
>                 struct smu_sdbp_sensortree *st =
>                         (struct smu_sdbp_sensortree *)&hdr[1];

The more common way of writing this in the kernel is 
"if (hdr)".

     Arnd
diff mbox series

Patch

diff --git a/drivers/macintosh/windfarm_pm121.c b/drivers/macintosh/windfarm_pm121.c
index 36312f163aac..82dcd35f439a 100644
--- a/drivers/macintosh/windfarm_pm121.c
+++ b/drivers/macintosh/windfarm_pm121.c
@@ -651,7 +651,7 @@  static void pm121_create_cpu_fans(void)

        /* First, locate the PID params in SMU SBD */
        hdr = smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL);
-       if (hdr == 0) {
+       if (hdr == NULL) {
                printk(KERN_WARNING "pm121: CPU PID fan config not found.\n");
                goto fail;
        }
@@ -970,7 +970,7 @@  static int pm121_init_pm(void)
        const struct smu_sdbp_header *hdr;

        hdr = smu_get_sdb_partition(SMU_SDB_SENSORTREE_ID, NULL);
-       if (hdr != 0) {
+       if (hdr != NULL) {
                struct smu_sdbp_sensortree *st =
                        (struct smu_sdbp_sensortree *)&hdr[1];
                pm121_mach_model = st->model_id;